Skip to content

Draft: feat: update to GeoServer 3#244

Closed
buehner wants to merge 1 commit into
masterfrom
geoserver-3
Closed

Draft: feat: update to GeoServer 3#244
buehner wants to merge 1 commit into
masterfrom
geoserver-3

Conversation

@buehner

@buehner buehner commented Nov 20, 2025

Copy link
Copy Markdown
Member

This is a branch for all the changes that are required to have the Dockerfile work with GeoServer 3.

It is WIP and should be merged, once GeoServer3 is officially released.

It is running fine with the current GeoServer3 Snapshot WAR file available. @jodygarnett I successfully tested all features of the docker image project (JNDI, CORS, GDAL, etc) and it is working fine! I could not find any issues.

Just try docker-compose -f docker-compose-demo.yml up --build

@buehner
buehner force-pushed the geoserver-3 branch 2 times, most recently from 7f6f10b to d557f63 Compare November 20, 2025 08:34
Comment thread Dockerfile

# For GeoServer 3.0.0 tomcat:11.0-jdk21-temurin-noble required
ARG GEOSERVER_BASE_IMAGE=tomcat:9.0.116-jdk17-temurin-noble@sha256:8ffb46723346c5bc7d4a5f56b9ee9295da3fac216a6de31d1c8cf07a0c8efe59
ARG GEOSERVER_BASE_IMAGE=tomcat:11.0-jdk21-temurin-noble

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buehner I think some of this is handled here:

Or is this PR changing the defaults, to be merged alongside 3.0 release?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The main intention is to keep track of the defaults.

For a long time, I did not realize that the release script uses the GEOSERVER_BASE_IMAGE argument. That's why I - at that time - introduced the renovate bot to ensure that we always have an explicit, up-to-date version in the Dockerfile.

This brings me to another thought: As the release script uses a non-explicit "generic" version for the base image, this might lead to unwanted behavior: Docker internally caches tagged images once they were downloaded. Unless explicitly using flags like --pull, Docker would NOT pull new versions, even if they are available on a hub. And those images usually update often in the docker world, so we - at least in theory - miss security updates etc.

So I created this PR to adress this potential issue: #292

@jodygarnett

Copy link
Copy Markdown
Member

So GeoServer 3.0.0 is released, but main-nightly has been failing for a little while.

Now that it is working I observe the following on build server:

Downloading GeoServer for version 3.1-SNAPSHOT
  Download GeoServer 3.1-SNAPSHOT
  Download nightly build from https://build.geoserver.org/geoserver/3.1.x
  downloading geoserver-3.1.x-latest-war.zip
Build step 'Execute shell' marked build as failure

The URL should be https://build.geoserver.org/geoserver/main/geoserver-main-latest-bin.zip

@jodygarnett

Copy link
Copy Markdown
Member

I think this PR has gone stale, as https://github.com/geoserver/docker/blob/master/build/release.sh presently makes a judgement call on which base image to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants