fix(native): use app .run for crash daemon - #1976
Open
jpnurmi wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
+ Coverage 74.31% 74.50% +0.18%
==========================================
Files 104 104
Lines 25638 25609 -29
Branches 4627 4621 -6
==========================================
+ Hits 19054 19081 +27
+ Misses 5281 5234 -47
+ Partials 1303 1294 -9 🚀 New features to boost your workflow:
|
Have the native crash daemon adopt the application's existing .run instead of creating a second unrelated .run, and store daemon logs, minidumps, crash envelopes, and signal-handler scratch files within that .run. Protect daemon-owned work with a dedicated `.run.daemon.lock` so old-run processing waits for completion. Keep retry cache and external storage database-global, and leave crashed runs for normal next-launch cleanup.
jpnurmi
force-pushed
the
jpnurmi/ref/native-run
branch
from
August 12, 2026 16:40
d373b92 to
d5faff5
Compare
jpnurmi
commented
Aug 13, 2026
| sentry_value_decref(crash_event); | ||
| } | ||
|
|
||
| // Send all other envelopes from run folder (logs, etc.) before cleanup |
Collaborator
Author
There was a problem hiding this comment.
Tip
👆 The other envelopes are now already processed earlier by the sentry__process_run_envelope call above. Such an extra envelope is already covered by test_native_session_tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have the native crash daemon adopt the application's existing
.runinstead of creating a second unrelated.run, and store daemon logs, minidumps, crash envelopes, and signal-handler scratch files within that.run.Before this change, every native crash daemon run left its log in the top-level database directory, while every generated minidump remained there after its crash. Neither files were in
.rundirectories, so old-run processing never removed them, so logs accumulated per daemon run and minidumps per qualifying crash.The daemon's unconditional retention of generated minidumps predates PR #1607 and is now redundant. With
cache_keepconfigured, thecache/directory retains each minidump as a separate.dmpalongside its.envelope, subject to configured cache limits. This provides the same direct debugger access without leaving raw minidumps in the database root indefinitely.Protect daemon-owned work with a dedicated
.run.daemon.lockso old-run processing waits for completion. Keep retry cache and external storage database-global, and leave crashed runs for normal next-launch cleanup.Tip
Making the native daemon play by the normal
.runrules is also a pre-requisite for implementingon_crashed_last_runin a clean way, hooked into the shared "process old runs" mechanism used by all backends:on_crashed_last_runcallback #1985