Skip to content

feat(data-collection): Port redis, net:http, faraday and excon - #3032

Open
sl0thentr0py wants to merge 1 commit into
neel/data-collection/requestfrom
neel/data-collection/integrations
Open

feat(data-collection): Port redis, net:http, faraday and excon#3032
sl0thentr0py wants to merge 1 commit into
neel/data-collection/requestfrom
neel/data-collection/integrations

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Jul 22, 2026

Copy link
Copy Markdown
Member

Makes url collection close to the table here. Note that we haven't renamed url to url.full yet, that will be done in the major.

Issues

@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 0282f43 to 6affacd Compare July 22, 2026 15:02
@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

RUBY-192

Comment thread sentry-ruby/lib/sentry/utils/http_tracing.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 6affacd to b0dfd58 Compare July 22, 2026 16:19
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from b0dfd58 to eea5790 Compare July 22, 2026 16:23
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from eea5790 to 10149e3 Compare July 23, 2026 12:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 10149e3. Configure here.

Comment thread sentry-ruby/lib/sentry/utils/http_tracing.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 10149e3 to 0b2ef30 Compare July 23, 2026 12:32
Comment thread sentry-ruby/lib/sentry/utils/http_tracing.rb

@solnic solnic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment thread sentry-ruby/lib/sentry/utils/http_tracing.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 0b2ef30 to c79d366 Compare August 10, 2026 12:06
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from c79d366 to a5b79c8 Compare August 10, 2026 12:08
Comment thread sentry-ruby/lib/sentry/redis.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from a5b79c8 to 28311d3 Compare August 10, 2026 12:23
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 28311d3 to 8b35800 Compare August 10, 2026 12:28
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 8b35800 to 3d58981 Compare August 10, 2026 12:30
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/integrations branch from 3d58981 to da0a3e0 Compare August 10, 2026 12:32
Comment on lines +28 to +32
def format_query(query)
query.flat_map do |key, value|
Array(value).map { |item| "#{key}=#{item}" }
end.join("&")
end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new format_query method incorrectly serializes nested hash query parameters, which is a regression from the previous build_nested_query implementation.
Severity: MEDIUM

Suggested Fix

Update the format_query method to recursively handle nested hashes, converting them into the correct bracketed notation for URL query strings. This can be achieved by reintroducing logic similar to the removed build_nested_query function to restore the previous functionality.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: sentry-ruby/lib/sentry/utils/http_tracing.rb#L28-L32

Potential issue: The refactoring in `filter_query_params` introduced a new
`format_query` method that does not correctly handle nested hash structures for query
parameters. The previous implementation used `build_nested_query`, which supported this
functionality. If a user provides a nested hash as a query parameter (e.g., `{qux: {a:
1}}`), the new logic will incorrectly serialize it to a string like `"qux=[:a=>1]"`
instead of the expected `"qux[a]=1"`. This is a regression that can lead to malformed
HTTP requests for integrations like Excon when complex query parameters are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pii): Wire third-party breadcrumbs (Faraday, Net::HTTP, Excon, Redis)

2 participants