Skip to content

[core] Inherit InstanceFlags in Device via Adapter#9915

Merged
Wumpf merged 1 commit into
gfx-rs:trunkfrom
sagudev:device-instance
Jul 25, 2026
Merged

[core] Inherit InstanceFlags in Device via Adapter#9915
Wumpf merged 1 commit into
gfx-rs:trunkfrom
sagudev:device-instance

Conversation

@sagudev

@sagudev sagudev commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Connections
As noted in #9901 (comment)

Description
Before wgc users needed to manually pass instance flags to request_device/create_device_and_queue_from_hal. We do not override them anywhere so we should just make them inheritable through Instance -> Adapter -> Device.

Testing
Just refactor

Squash or Rebase?

Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>

@Wumpf Wumpf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, less error prone too!

@Wumpf
Wumpf merged commit 27597cf into gfx-rs:trunk Jul 25, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants