-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: register extensions for the active integration only #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mnriem
merged 55 commits into
github:main
from
marcelsafin:fix/2948-active-only-extension-registration
Jul 27, 2026
Merged
Changes from 4 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
af9205f
fix: register extensions for the active integration only
marcelsafin e9e9072
fix: address review feedback on active-only extension registration
marcelsafin 2486c08
fix: address second round of review feedback (priority order, fail-cl…
marcelsafin 12a3d67
fix: address third round of review feedback (multi-integration semant…
marcelsafin db78903
fix: address fourth round of review feedback (skill registration prov…
marcelsafin e5d5553
fix: address fifth round of review feedback (symlink presence, rescaf…
marcelsafin fc7b2e2
fix: guard skill subdirectories and active-agent scoping in preset re…
marcelsafin 5b0e559
fix: persist command registration before fallible skills phase on res…
marcelsafin b9d9053
fix: unregister stale opposite-mode preset artifact on same-agent ski…
marcelsafin 3a1e749
fix: migrate legacy flat-list registered_skills on rescaffold even wh…
marcelsafin 1bdb5b3
fix: reconcile before fallible skills phase, infer legacy skill prove…
marcelsafin ee03a50
fix: broaden legacy skill provenance inference to command-backed agents
marcelsafin 37cceb7
fix: preserve extension skill tracking for mirrors in other agent dirs
marcelsafin 28561e6
fix: reject symlinked skills-directory escape in extension skill scans
marcelsafin 1d8f9e3
Fix unscoped extension-skill removal and legacy preset provenance on …
marcelsafin 0ab9a5f
Keep unregister_agent_artifacts scoped to its agent when directory is…
marcelsafin 31c9b97
Preserve global skill tracking across agents in unregister_agent_arti…
marcelsafin ab6c28c
Reconcile every historical agent on preset removal; validate child sk…
marcelsafin f19225a
Persist historical reconciliation ownership; defer destructive toggle…
marcelsafin d0d152e
Verify replacement actually landed before retiring stale toggle artif…
marcelsafin 664dfbe
Retire alias command groups on toggle; scope preset cleanup to switch…
marcelsafin b64937a
fix: track reconciled extension artifacts
marcelsafin 170ca14
Fix native skill preset reconciliation
marcelsafin bee8c77
Fix shared native skill cleanup
marcelsafin b500653
Fix partial preset rescaffold tracking
marcelsafin 1c99743
Fix preset agent skill lifecycle
marcelsafin bd31afb
Clarify preset removal reconciliation
marcelsafin 1ebcb3a
fix(integrations): address upgrade review feedback
marcelsafin 53a914a
Merge upstream/main into fix/2948-active-only-extension-registration
marcelsafin f38a6b8
fix(presets): reconcile partial command writes
marcelsafin 8df78fa
fix: address active artifact cleanup review
marcelsafin e341171
fix: defer preset skill cleanup to winning command
marcelsafin aac24f3
fix: track reconciled and partial preset skills
marcelsafin 7b546dd
fix: reconcile project overrides to legacy skills
marcelsafin 1c63273
fix: harden preset skill writes and rollback
marcelsafin 4a3b5d2
fix(presets): harden legacy skill restoration
marcelsafin ba26475
fix(presets): preserve non-owned legacy skills
marcelsafin baa3f68
fix: validate reconciled skill paths
marcelsafin 20223a2
fix(presets): preserve reconciled skill ownership
marcelsafin dec29f8
fix(presets): clean reconciled agent skills
marcelsafin 41a2d30
fix: keep legacy cleanup project-local
marcelsafin 1d6ca9b
fix(presets): keep active agent's artifacts in its current mode on re…
marcelsafin f918be5
Merge remote-tracking branch 'upstream-main' into fix/2948-active-onl…
marcelsafin eaa8798
fix: filter uninstalled-extension commands in reconciliation; allow a…
marcelsafin d24b5de
fix: reject active layout change while a disabled preset owns artifacts
marcelsafin e3d9bc1
docs: replace placeholder prefix in two safety comments
marcelsafin 3d3098f
docs: correct guard-helper docstring to active-only registration model
marcelsafin b0695bb
fix: fail closed on non-list values in per-agent preset provenance
marcelsafin b8f1b71
fix: drop eager extension unregister on layout-changing upgrade
marcelsafin 4324ebc
fix: rescaffold fallback integration after failed switch rollback
marcelsafin a9946ce
docs: explain load-bearing pre-create loop in _reconcile_skills
marcelsafin 7bf0b67
Merge upstream/main and restore preset layout guard
marcelsafin 1dfd32c
fix: preserve dashed-description skill tracking
marcelsafin 8f98a77
fix: skip absent extension skills during reconciliation
marcelsafin 97e74ad
fix: preserve partial native skill cleanup
marcelsafin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.