This update changes the Swift names of types declared within Java interfaces when default @SwiftName rules are being applied. Previously, a type Bar declared within interface Foo would be translated to a top-level type with Swift name Bar. This could cause problems if another interface Biz also declared an inner type Bar. Now the Swift type name will be formed by concatenating the interface and inner type name: FooBar. This also matches KMP's Swift naming of inner types within interfaces. - #2831
Open
copybara-service[bot] wants to merge 1 commit into
Open
This update changes the Swift names of types declared within Java interfaces when default @SwiftName rules are being applied. Previously, a type Bar declared within interface Foo would be translated to a top-level type with Swift name Bar. This could cause problems if another interface Biz also declared an inner type Bar. Now the Swift type name will be formed by concatenating the interface and inner type name: FooBar. This also matches KMP's Swift naming of inner types within interfaces.#2831copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…erfaces when default @SwiftName rules are being applied. Previously, a type Bar declared within interface Foo would be translated to a top-level type with Swift name Bar. This could cause problems if another interface Biz also declared an inner type Bar. Now the Swift type name will be formed by concatenating the interface and inner type name: FooBar. This also matches KMP's Swift naming of inner types within interfaces. PiperOrigin-RevId: 964107865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update changes the Swift names of types declared within Java interfaces when default @SwiftName rules are being applied. Previously, a type Bar declared within interface Foo would be translated to a top-level type with Swift name Bar. This could cause problems if another interface Biz also declared an inner type Bar. Now the Swift type name will be formed by concatenating the interface and inner type name: FooBar. This also matches KMP's Swift naming of inner types within interfaces.