Prefix json_annotation helpers when imported with a prefix - #1588
Open
AzazelSensei wants to merge 1 commit into
Open
Prefix json_annotation helpers when imported with a prefix#1588AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Generated `$checkedCreate`, `$checkKeys`, and `$enumDecode*` calls now honor an import prefix on `package:json_annotation`, fixing checked-mode and enum decode analyze errors. Fixes google#1199 Fixes google#1115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonAnnotationHelperPrefixhelper that returns''or'prefix.'for thepackage:json_annotationimport.$checkedCreate,$checkKeys, and$enumDecode/$enumDecodeNullablecalls with that prefix.$checkedConvertunqualified; it is the local callback parameter name inside$checkedCreate.Fixes #1199
Fixes #1115
Follows the review direction from #1116: one prefix helper, no scattered ifs.
Test plan
dart test test/json_serializable_test.dart(includes newCheckedWithPrefix/EnumWithPrefixgoldens)dart test test/integration/integration_test.dart(includes new prefixed import round-trip)dart test test/enum_helper_test.dart