ci(consolidation): arm permanent migration gates#46
Merged
Conversation
Captured-essence ledger Scope inventory: the #5 proof estate—65 checked-in L0.exact fixtures, five legacy seam architecture locks, workspace Cargo.lock, the frozen wasm build, and the n0 shot/timing baselines. Caveats and provenance: the full iosvg resvg suite remains local-only (4,351 byte-identical PNGs recorded by #5 and 7c101b9); L0.exact is the declared CI subset; seam tests are lexical dependency locks; machine-local shot drift and timing variance are recorded in #5 and #44. Re-home: CI now owns stable required checks, exact corpus plus renderer A/B evidence, additions-only crate-cut proof, and a pinned Ubuntu n0 baseline identity. Candidate baselines are complete, review-only artifacts until separately adopted with etiology. Deliberate drops: none. This commit changes no renderer behavior, fixture, schema, package metadata, golden, or baseline file. The aarch64-macos baseline remains until a genuine Ubuntu CI candidate is inspected.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (8)
WalkthroughAdds a consolidation-gates workflow with conditional Rust, lockfile, pixel-sweep, and N0 checks. Adds revision comparison scripts and changes N0 baselines to use host ownership, provenance metadata, deterministic non-owner checks, and staged baseline candidates. ChangesConsolidation gates and baseline validation
Estimated code review effort: 5 (Critical) | ~90 minutes Sequence Diagram(s)sequenceDiagram
participant PullRequest
participant Scope
participant ConsolidationGates
participant N0Gate
participant Baselines
PullRequest->>Scope: determine base, head, and engine scope
Scope->>ConsolidationGates: run applicable gates
ConsolidationGates->>N0Gate: execute host-aware gate
N0Gate->>Baselines: read or stage baseline metadata
Baselines->>ConsolidationGates: return gate result
ConsolidationGates->>PullRequest: publish consolidated status
Possibly related issues
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Run 29699083578 proved the n0 job timeout was build topology, not renderer output: n0_dev completed its cold release build in 16m24s, then cargo selected a second skia-bindings graph for gate and was cancelled 12m40s later at the 30-minute job ceiling. The candidate and upload steps never ran, and the interrupted cache save failed. Build n0_dev and gate in one Cargo invocation so their features resolve once, execute the resulting gate binary directly, and retain a 45-minute cold-host ceiling. The fail-closed sequence is unchanged: an unblessed failure may produce a complete review-only candidate, then the job remains red until that candidate is deliberately adopted. Gate evidence: the exact combined release build passes locally; direct non-owner gate execution passes shots, replay, differential, cache, and timing paths; YAML parsing and git diff checks pass. Frozen format and published package surfaces remain untouched.
Adopt the complete review-only candidate from GitHub Actions run 29700301719, artifact 8446425713 (zip SHA-256 469e3fbf2a526611f61f1d43220dc966bcc414ba290595dd0e97d6b2f3fed978). The manifest records source ed0f310, ubuntu-24.04 x86_64, Rust 1.92.0, and skia-safe 0.93.1. Captured essence: preserve all four named 1360x900 RGBA states, paired shot/timing ownership, same-host determinism, replay determinism, the ENG-0.2 differential, scene-cache equality, and the generous max(1.5x, +50us) timing rule. The candidate gate passed every portable check before installing and uploading exactly five files. Etiology: the outgoing images came from 7c101b9 on aarch64-macos. Main commit abe0305 then deliberately changed the footer from the plan-code name anchor spike — E10 to n0_dev — anchor spike without updating the shots; that source change accounts for exactly 4,010 pixels in each current macOS render. Comparing current source across macOS and Ubuntu changes 2,627-3,992 pixels per shot (0.215-0.326%); visual diffs are confined to text rasterization, while geometry and colors align. The timing numbers move from incomparable macOS measurements to CI-owned min-of-11 measurements: starter 15.639/1.654us and flat10k 1076.711/269.591us for resolve/build. This is an authority transfer, not a performance claim. Deliberate drop: retire only aarch64-macos baseline authority and the stale E10 footer pixels. Preserve their provenance here and in #5/#44. format/grida.fbs, the published canvas-wasm freeze, probe-baseline.json, renderer behavior, and fixture content remain untouched.
This was referenced Jul 19, 2026
softmarshmallow
marked this pull request as ready for review
July 20, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This executes exactly the first open consolidation step on #43: Phase 0 CI arming.
consolidation gates / armedcheckL0.exactsubset across base and headubuntu-24.04This does not begin the decision-issue filing sweep, either docs lane, the cg crate cut, or scoreboard v0.
Etiology
Presentation: clean main has no permanent CI form of #5's one-time consolidation proofs, and the n0 gate is red on a different host while CI does not run it.
Proximate cause: the four shot goldens and timing budgets are identified as
aarch64-macos; shot comparison is unconditional, timing comparison silently skips other machines, and a missing benchmark baseline could silently become a new local baseline.Contract: portable replay/differential checks and environment-owned raster/timing checks were conflated, with no explicit baseline owner or fail-closed CI bootstrap.
Systemic boundary: pixels and timings vary with the raster stack and host. The gate now pins ownership to one CI host, while non-owners prove same-host shot determinism and run every portable check without comparing incomparable environments.
Captured-essence ledger
Scope inventory
fixtures/test-html/suites/L0.exact.jsonCargo.toml/Cargo.lockcrates/n0/rig/baselines.jsoncrates/n0/rig/probe-baseline.json, inventoried but outside this gateCaveats with provenance
fixtures/localand remains a named per-PR local-only sweep.7c101b9b, and gate: CI-hosted run with CI-blessed baselines #44 record the machine-local shot drift and timing variance that require CI ownership.probe-baseline.jsonhas no live gate reader and is not silently deleted.Re-home destination
bin/check-legacy-pixel-sweepseam architecturejobbin/check-cargo-lock-additions-onlycanvas build / build, now present on every PRDeliberate drops
None in the harness commit. No renderer behavior, fixture, schema, package metadata, golden, or baseline file changes.
The inspected baseline adoption commit
df3d5b5bretires only the old aarch64-macos authority and the staleanchor spike — E10footer pixels. Commitabe0305dintentionally renamed that live text after the outgoing goldens were recorded; the visual patrol isolated exactly 4,010 changed pixels per local shot to that rename. Current-source macOS↔Ubuntu differences affect 2,627–3,992 pixels per shot (0.215–0.326%) and are confined to text rasterization; geometry and colors align. The old measurements remain preserved in commit history and this ledger.format/grida.fbs, the published@grida/canvas-wasm@0.91.0-canary.22, andprobe-baseline.jsonare untouched.Local gate evidence
cargo fmt --all -- --checkcargo clippy --locked -p n0 --bin gate -- -D warningscargo test --locked -p grida— 828 unit tests plus integration/doc tests greencargo test --locked -p n0-model -p n0— greenf1892dcdab29442eaarch64-macos+100/-0, greenRemote gate evidence
skia-bindingsbuild; no gate binary, candidate, or artifact ran. Commited0f3109unified the shot host and gate into one Cargo graph and retained a 45-minute hard ceiling.8446425713(zip SHA-256469e3fbf2a526611f61f1d43220dc966bcc414ba290595dd0e97d6b2f3fed978).ed0f3109431587c99d25244542c89631060d8bdf,github-actions-ubuntu-24.04-x86_64, Rust 1.92.0, and skia-safe 0.93.1. All five adopted files are byte-identical to the inspected artifact.armed: four shotsIDENTICAL; replays deterministic; references deterministic; scene cache matches fresh; starter 15.9/1.7 µs and flat10k 1085.8/273.1 µs are within their CI budgets. Candidate, upload, and bootstrap-failure steps were skipped.Bootstrap and owner gate
The paired bootstrap completed on pinned Ubuntu: it produced a complete candidate only after every portable gate passed, and the candidate was inspected before adoption. The final unblessed run is green and skipped candidate production. The PR remains draft; all-green CI is evidence, not approval.
Do not merge without explicit owner GO.
Closes #44.