fix(fabric-api): download runtime JAR from GitHub Releases - #142
Merged
Conversation
The `fabric-api` input downloaded the top-level Maven artifact, which for some legacy releases (e.g. 0.77.0+1.18.2) is a thin aggregator JAR with no nested runtime submodules. Mods depending on Fabric API submodules then failed at runtime with NoClassDefFoundError. Use robinraju/release-downloader to fetch the official `fabric-api-<version>+<mc>.jar` asset from FabricMC/fabric-api releases, which is the complete end-user distribution for both legacy and modern publications. Closes #141
okafke
self-requested a review
July 15, 2026 18:29
okafke
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fabric-apiinput downloaded the top-level JAR from Fabric's Maven repo. For some older releases that JAR is a thin aggregator with no bundled submodules, so mods depending on Fabric API submodules crash at runtime (e.g.NoClassDefFoundErrorforfabric-networking-api-v1).Example: Maven
0.77.0+1.18.2is 4,877 bytes with 0 nested modules, while the GitHub Release JAR is 1.47 MB with 45. Fabric fixed this in the 1.19.2 branch but never backported it, so it only breaks on older versions.This switches the download to
robinraju/release-downloader, pullingfabric-api-<version>+<mc>.jarfrom FabricMC/fabric-api releases. The release asset is the full distribution for both old and new versions.Note: the source moves from Fabric's Maven CDN to the GitHub release API.
release-downloaderusesGITHUB_TOKEN, so rate limits shouldn't bite in normal CI.Closes #141