Skip to content
This repository was archived by the owner on May 20, 2024. It is now read-only.

Add in ApplyBCPatch macro system - #16

Open
KoenigKrote wants to merge 13 commits into
hydroframe:masterfrom
KoenigKrote:bc_patch_dsl
Open

Add in ApplyBCPatch macro system#16
KoenigKrote wants to merge 13 commits into
hydroframe:masterfrom
KoenigKrote:bc_patch_dsl

Conversation

@KoenigKrote

@KoenigKrote KoenigKrote commented Jun 19, 2019

Copy link
Copy Markdown

In progress to #9 #14 #15

Note: Primary work and changes live in bc_faces.h and in richards_jacobian_eval.c, rest of macros are setting up loop changes to work with this system.

Current progress:

  • Set up ForBCStructNumPatches macro
  • Design a macro system for applying BC contributions (ApplyBCPatch)
  • Set up BCStructPatchLoopX, GrGeomPatchLoopX, and GrGeomOctreeFaceLoopX macro to handle ApplyBCPatch macro
  • Convert RichardsJacobian Symmetric contribution loop to use new macro system
  • Convert RichardsJacobian Boundary Condition Contribution loops to use new macro system
  • Convert RichardsJacobian JC Submatrix loop to use new macro system
  • DirichletBC Pressure Contribution Macro #14 DirichletBC Pressure macro written, needs to be removed from this PR and into its own
  • [?] Boundary Condition Macro System - NL Function Eval #15 Apply macro system to NlFunctionEval
    • Precondition / Postcondition macros
  • Compiles correctly
  • Document system
  • Decide how to handle outer iteration spaces, specify them directly or use Do_ macro verbage?
  • Decide on specific naming schemes
  • Decide on specific header file organization
  • Determine which macro systems can be used in both Richards and NL (i.e. where can we remove "Richards" from the Do_* macros and also use them in NlFunctionEval)
  • Verify output
  • Check performance changes (in serial)

@KoenigKrote KoenigKrote self-assigned this Jun 19, 2019
@KoenigKrote

Copy link
Copy Markdown
Author

It would make the most sense the finalize and merge adding boundary condition macros before continuing to review this procedure, since we want to add/merge additional OverlandFlow cases anyways

chinwendumnjoku97 pushed a commit that referenced this pull request Jun 10, 2021
* Switched ZYX to XYZ

* Trying to shorten CI time
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant