1210: Add contained_by association for CpuCore interface - #769
Open
baemyung wants to merge 1 commit into
Open
Conversation
Cpu & CpuCore is expressed via associations `{containing, contained_by}`
in the phosphor-dbus-interfaces specification [1].
This commit is to implement an example code change to create the
association in pldm.
Example:
CpuCore: /xyz/openbmc_project/inventory/.../cpu0/core0
Association: contained_by -> /xyz/openbmc_project/inventory/.../cpu0
[1] openbmc/phosphor-dbus-interfaces@8c79b1d
Signed-off-by: Myung Bae <myungbae@us.ibm.com>
Author
|
This commit is an example backend pldm implementation to create the association The related upstream commits:
1210 bmcweb PR: ibm-openbmc/bmcweb#1488 Note: depending on the target release of PLDM implementation, bmcweb may change its target release. |
|
Can one of the admins verify this patch? |
jaypadath
requested changes
Jun 19, 2026
jaypadath
left a comment
jaypadath
left a comment
Contributor
There was a problem hiding this comment.
In P12, Processor Cores are not hosted by PLDM and its done by PIM. So this code change has no effect for Huygens systems.
| { | ||
| cpuCore.emplace(path, std::make_unique<CPUCore>( | ||
| pldm::utils::DBusHandler::getBus(), path)); | ||
|
|
Contributor
There was a problem hiding this comment.
PIM hosts Processor and Processor cores, so the Processor - Processor core association should be added by Phosphor-dbus-interface.
Since the PLDM changes are no longer in use, this commit can be dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cpu & CpuCore is expressed via associations
{containing, contained_by}in the phosphor-dbus-interfaces specification [1].This commit is to implement an example code change to create the association in pldm.
Example:
CpuCore: /xyz/openbmc_project/inventory/.../cpu0/core0
Association: contained_by -> /xyz/openbmc_project/inventory/.../cpu0
This association is going to be used in bmcweb - e.g. upstream commits [2][3]
[1] openbmc/phosphor-dbus-interfaces@8c79b1d
[2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/38570
[3] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/64982