New Crowdin updates - #1373
Conversation
Greptile SummaryThis PR syncs new Crowdin translation keys for the
Confidence Score: 4/5Safe to merge as a standalone translation sync, but the companion change to add these keys to en-US.json must land before the CreateInvoiceModal feature ships. The 6 new keys added to all 9 non-English locales are absent from en-US.json. The component doesn't reference them yet, so no user-visible breakage today — but when the feature lands, English users will see raw key strings. The change itself is low-risk boilerplate; the gap is a real defect that needs to be closed before the feature is enabled. All 9 locale files are consistent with each other. The file that needs attention before the feature ships is src/i18n/locales/en-US.json, which is not part of this PR.
|
| Filename | Overview |
|---|---|
| src/i18n/locales/de-DE.json | Adds 6 new CreateInvoiceModal keys with untranslated English values; mirrors the same pattern as all other locales in this PR. |
| src/i18n/locales/es-ES.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/fr-FR.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/it-IT.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/ja-JP.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/ko-KR.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/pt-BR.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/ru-RU.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
| src/i18n/locales/zh-CN.json | Adds 6 new CreateInvoiceModal keys with untranslated English values. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Component requests i18n key\ne.g. CreateInvoiceModal.memoLabel] --> B{Key in active locale?\ne.g. de-DE.json}
B -- Yes --> C[Render translated string\ne.g. German text]
B -- No --> D{fallbackLng: en-US.json}
D -- Key found --> E[Render English string]
D -- Key NOT found\ncurrent state --> F[Render raw key string\n❌ Broken UI for English users]
style F fill:#ff6b6b,color:#fff
style E fill:#51cf66,color:#fff
style C fill:#51cf66,color:#fff
Reviews (1): Last reviewed commit: "[ci skip] add new translations for Portu..." | Re-trigger Greptile
| "cmps.designer.lightning.actions.CreateInvoiceModal.memoLabel": "Memo", | ||
| "cmps.designer.lightning.actions.CreateInvoiceModal.memoPlaceholder": "Optional description for this invoice", | ||
| "cmps.designer.lightning.actions.CreateInvoiceModal.expiryLabel": "Expiry (seconds)", | ||
| "cmps.designer.lightning.actions.CreateInvoiceModal.expiryPlaceholder": "Leave blank for node default", | ||
| "cmps.designer.lightning.actions.CreateInvoiceModal.expiryTooltip": "How long the invoice remains valid. Leave blank to use the node's default.", | ||
| "cmps.designer.lightning.actions.CreateInvoiceModal.advancedOptions": "Advanced Options", |
There was a problem hiding this comment.
New keys missing from
en-US.json (the fallback locale)
The 6 new keys (memoLabel, memoPlaceholder, expiryLabel, expiryPlaceholder, expiryTooltip, advancedOptions) are added to all 9 non-English locale files but are absent from src/i18n/locales/en-US.json. Because i18n/index.ts sets fallbackLng: 'en-US', i18next falls back to en-US.json when a key is missing — but if the key isn't there either, it renders the raw key string. When the CreateInvoiceModal component is updated to reference these keys, English-speaking users will see strings like cmps.designer.lightning.actions.CreateInvoiceModal.memoLabel in the UI. The same gap exists across all 9 locales in this PR.
No description provided.