🧪 add test for pending count dropping below zero#35
Conversation
- Added new test file `src/__tests__/Squawk.pending.test.ts`
- Verifies that calling store.pending("prop", false) throws an Error when count is already 0
- Included happy path test to verify normal pending true/false usage
- Improves testing coverage for Squawk error conditions
Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed is a missing test ensuring that
store.pending(prop, false)throws an error if called beforestore.pending(prop, true), verifying that the pending count cannot drop below zero.📊 Coverage: Scenarios covered include:
store.pending(prop, false)when the pending count is zero, asserting the correct errorToo many calls to pending(..., false)is thrown.store.pending(prop, true)followed bystore.pending(prop, false)doesn't throw.✨ Result: Test coverage improved for Squawk action edge cases, specifically preventing erroneous decrementing of pending counter.
PR created automatically by Jules for task 14618274811946718794 started by @johnstrand