Skip to content

🧪 add test for pending count dropping below zero#35

Merged
johnstrand merged 1 commit into
masterfrom
add-test-pending-dropping-below-zero-14618274811946718794
Jul 10, 2026
Merged

🧪 add test for pending count dropping below zero#35
johnstrand merged 1 commit into
masterfrom
add-test-pending-dropping-below-zero-14618274811946718794

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed is a missing test ensuring that store.pending(prop, false) throws an error if called before store.pending(prop, true), verifying that the pending count cannot drop below zero.

📊 Coverage: Scenarios covered include:

  • Calling store.pending(prop, false) when the pending count is zero, asserting the correct error Too many calls to pending(..., false) is thrown.
  • Normal happy path usage: setting store.pending(prop, true) followed by store.pending(prop, false) doesn't throw.

Result: Test coverage improved for Squawk action edge cases, specifically preventing erroneous decrementing of pending counter.


PR created automatically by Jules for task 14618274811946718794 started by @johnstrand

- Added new test file `src/__tests__/Squawk.pending.test.ts`
- Verifies that calling store.pending("prop", false) throws an Error when count is already 0
- Included happy path test to verify normal pending true/false usage
- Improves testing coverage for Squawk error conditions

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand
johnstrand merged commit faaaace into master Jul 10, 2026
1 check passed
@johnstrand
johnstrand deleted the add-test-pending-dropping-below-zero-14618274811946718794 branch July 10, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant