ci: fix pnpm setup failure, pin toolchain with mise - #1
Merged
Conversation
CI was failing at the "Setup pnpm" step on every run:
Error: No pnpm version is specified.
pnpm/action-setup@v4 requires the pnpm version to come from either its
`version` input or package.json's `packageManager` field, and neither was
present.
Fixes and improvements:
- Add mise.toml pinning exact LTS versions (node 24.18.0, pnpm 10.34.4)
as the single source of truth for local dev and CI.
- Add `packageManager` and `engines.node` to package.json.
- Drive CI tool versions from mise.toml via jdx/mise-action; apply the
same setup to the release workflow, which had the identical bug.
- Cache the pnpm store and cancel superseded runs (concurrency).
- Add a Prettier format check (`format:check` script) to CI, with a
.prettierignore so generated files (lockfile, dist) are skipped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018JWDajbftveEqqZWcrFH5n
Apply the repo's Prettier config (semi: false) across the codebase so the new CI format check passes. Purely cosmetic — no behavioral changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018JWDajbftveEqqZWcrFH5n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI has been failing on every run at the
Setup pnpmstep:pnpm/action-setup@v4needs the pnpm version from either itsversioninput or apackageManagerfield inpackage.json— neither existed, so the job died before installing anything.release.ymlhad the identical bug.What changed
Fix the failure + pin the toolchain
mise.tomlpinning exact LTS versions —node = 24.18.0(latest Krypton LTS) andpnpm = 10.34.4(latest 10.x, matchinglockfileVersion: 9.0). One source of truth for local dev and CI.packageManager: "pnpm@10.34.4"andengines.node: ">=24"topackage.json.mise.tomlviajdx/mise-actionin bothci.ymlandrelease.yml(replacing the unpinnedpnpm/action-setup+setup-node). Release keeps npm auth via an explicit~/.npmrc.CI improvements (the "add anything that feels right" part)
pnpm-lock.yaml.concurrencywithcancel-in-progressto drop superseded runs and save minutes.format:checkstep + newformat:checkscript, with a.prettierignoreso generated files (lockfile,dist, changelogs) are never reformatted.Formatting normalization (separate commit)
semi: false), no behavioral changes.Verification
pnpm install --frozen-lockfile(lockfile unchanged),typecheck,lint,test(43 passing),build, andformat:checkall pass locally. ThepackageManagerfix directly resolves the exact error from the failing CI logs.Note: this only touches CI/tooling and formatting — no library code behavior changes, so it's safe ahead of the first public release.
🤖 Generated with Claude Code
https://claude.ai/code/session_018JWDajbftveEqqZWcrFH5n
Generated by Claude Code