feat(scenes): storyboard passthrough for scrubber previews - #22
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
kino | 6fdf319 | Commit Preview URL Branch Preview URL |
Jul 20 2026, 07:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds storyboard support to the scenes provider so kino's scrubber shows thumbnail previews on hover for scene sequences, exactly as it already does for Mux sources.
ScenesProviderOptions(and thereforeScenesPlayer) gainstoryboard?: { vttUrl }. When set, the provider reportscapabilities.hasStoryboard: trueandstate.storyboard = { vttUrl }; when absent, behavior is unchanged (false/null).SceneManifestgains an optionalstoryboard?: stringfield recording where the thumbnail VTT lives. It is read by embedding players, not by the host.Why
The scrubber already consumes
state.storyboard.vttUrlpluscapabilities.hasStoryboardand parses Mux-style thumbnail VTTs (#xywhfragments into a sprite image). The scenes provider only needed to surface the same shape. The karnstack ship pipeline generates the sprite grid and VTT per sequence and uploads them alongside the bundle; the caller passes the (possibly token-bearing) VTT URL in, and kino never touches the auth layer.Testing
hasStoryboard: falseandstoryboard: null.pnpm typecheck && pnpm lint && pnpm test && pnpm format:check && pnpm build(157 tests, 24 files, all green).