Skip to content

feat(analytics): self-hosted Umami tracker on keepsimple.io #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manager merged 1 commit into from
Aug 12, 2026
Merged

feat(analytics): self-hosted Umami tracker on keepsimple.io #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Font passport
<!-- font-passport: allowed=8,9,9.14,9.5,10,10.5,11,11.5,11.52,12,12.5,13,13.5,13.6,13.76,14,14.344,14.4,15,16,17,17.6,18,18.4,20,21,22,22.4,23,24,25,26,28,30,32,34,34.56,35,36,38,40,45,48,64,76; floor=8; contrast=4.5 -->
- Allowed sizes: **8, 9, 9.14, 9.5, 10, 10.5, 11, 11.5, 11.52, 12, 12.5, 13, 13.5, 13.6, 13.76, 14, 14.344, 14.4, 15, 16, 17, 17.6, 18, 18.4, 20, 21, 22, 22.4, 23, 24, 25, 26, 28, 30, 32, 34, 34.56, 35, 36, 38, 40, 45, 48, 64, 76px**. Hard floor: **8px**.
- Contrast: **4.5:1** minimum, or **3:1** for text at 18px and above.
- If text does not fit, fix the layout. This passport outranks template and skill defaults.

# CLAUDE.md — keepsimple (for Claude Code agents)

> **Global rules apply.** Communication style + Agent Directory routing live in `~/.claude/CLAUDE.md` — read that first. This project participates in the directory; use `/send-to` to ask peers.
Expand Down
10 changes: 9 additions & 1 deletion src/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,15 @@ class MyDocument extends Document {
render() {
return (
<Html>
<Head />
<Head>
{/* Umami, self-hosted, cookieless. data-domains keeps preview/staging traffic out. */}
<script
defer
src="https://analytics.administration.ae/script.js"

@github-actions github-actions Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: third-party script domain doesn't match the "self-hosted" claim.

The PR description says this is a "self-hosted Umami tracker," but the script is loaded from analytics.administration.ae — a domain unrelated to keepsimple.io or any KeepSimple-owned infrastructure I can find in this repo. That's a meaningful discrepancy:

  • This unconditionally injects third-party JS with full DOM/page access into <Head> on every render (dev, staging, prod, preview) — unlike GA/Mixpanel, which are lazy-loaded and gated behind NEXT_PUBLIC_INDEXING (see src/pages/_app.tsx:48,147,236). data-domains only filters what Umami records; it does not stop the script from loading and executing on every deploy.
  • A compromised or unverified third-party origin serving script.js here can read cookies/localStorage, exfiltrate data, or modify the DOM — full script-injection blast radius.
  • If this is genuinely self-hosted, the script origin should be KeepSimple-owned infra (e.g. analytics.keepsimple.io), not an unrelated third-party domain.

Please confirm analytics.administration.ae is an intentionally provisioned, trusted endpoint before merging. If it is, consider:

  • Sourcing the URL/website-id from an env var (NEXT_PUBLIC_UMAMI_*) rather than hardcoding, so staging/prod and endpoint rotation don't require code changes.
  • Adding integrity (SRI) if the endpoint supports versioned/immutable script hashes, since this loads on every page unauthenticated.

Fix this →

data-website-id="7fbd94ec-0f10-4b46-bd04-d0df64a58c9e"
data-domains="keepsimple.io,www.keepsimple.io"
/>
</Head>
<body>
<script dangerouslySetInnerHTML={{ __html: themeBootstrap }} />
<Main />
Expand Down
Loading