Skip to content

Re-add "triage" label when re-opening an issue via email - #73

Merged
stianst merged 1 commit into
keycloak:mainfrom
abstractj:issue-72
Jun 2, 2026
Merged

Re-add "triage" label when re-opening an issue via email#73
stianst merged 1 commit into
keycloak:mainfrom
abstractj:issue-72

Conversation

@abstractj

Copy link
Copy Markdown
Contributor

Closes #72

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by code review

@stianst stianst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced about this; not that this doesn't improve the current state, but think we should do something else.

I've opened #77 which is an issue where the bug re-opens fixed CVEs when there is a new reply, but would like to find a solution to both these in one go.

I can see two potential routes for a solution to both:

  • Don't re-open closed issues, but rather just reply to the mailing list that this issue is now closed
  • Re-open issues, but add labels so we can identify they where re-opened rather than putting them back to triage (status/re-opened-by-bot)?

var issue = issueOpt.get();
if (issue.getState() == GHIssueState.CLOSED) {
issue.reopen();
issue.addLabels(Labels.STATUS_TRIAGE);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this a bit more for now we can just add a label to indicate the bot has re-opened the issue; then if it becomes a bigger problem that many issues are re-opened we can re-consider. So I propose something like this:

Suggested change
issue.addLabels(Labels.STATUS_TRIAGE);
issue.addLabels(Labels.STATUS_TRIAGE, Labels.REOPENED_BY_BOT);

Co-authored-by: Stian Thorgersen <stianst@gmail.com>

Closes keycloak#72

Signed-off-by: Bruno Oliveira da Silva <bruno@abstractj.com>
@abstractj

Copy link
Copy Markdown
Contributor Author

@stianst updated.

@stianst
stianst merged commit d22839e into keycloak:main Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-add "triage" label when re-opening an issue via email

3 participants