Update docs site configuration - #685
Open
chris-s-friedman wants to merge 3 commits into
Open
Conversation
sphinx 7 removes support for the `style` html key used in sphinx-rtd version that is pinned in kf-sphinx-rtd theme. see https://www.sphinx-doc.org/en/master/changes.html#release-7-0-0-released-apr-29-2023
Contributor
Author
|
looking in circle ci, looks like it doesn't have access to versions of sphinx greater than 5.x.x - @znatty22 wondering if you have thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the docs site configuration
The docs site uses the custom kf-sphinx-docs-theme which has a pinned dependency on sphinx-rtd-theme 0.4.3. This older version of sphinx-rtd-theme uses the html
stylekey. Sphinx 7.0.0 deprecated support forstyle, so dependency is pinned to the last release of sphinx 6.x.x until the kf-sphinx-docs-theme pin of sphinx-rtd-theme is upgraded.