Skip to content

Fix cancelled install temp-directory cleanup (audit-resource-lifecycle-audit-002) - #97

Merged
kitsuyui merged 1 commit into
mainfrom
fix/audit-resource-lifecycle-audit-002
Aug 16, 2026
Merged

Fix cancelled install temp-directory cleanup (audit-resource-lifecycle-audit-002)#97
kitsuyui merged 1 commit into
mainfrom
fix/audit-resource-lifecycle-audit-002

Conversation

@kitsuyui

Copy link
Copy Markdown
Owner

Fix implemented

  • Added parent-side temporary workspace cleanup in install-app-async-core so cancellation now removes temporary directories deterministically.
  • Passed tmpPath to install-app-forked-lite so the child uses the same workspace while retaining its existing cleanup fallback.
  • Maintained existing install success/error IPC semantics and finalization flow.

Verification

  • Not run in this implementation step: no test execution requested.

Closes: audit-resource-lifecycle-audit-002

@github-actions

Copy link
Copy Markdown

gh-counter

PR gate

Removed Added +/-
TODO/FIXME 0 0 0
Type escape 0 0 0
Lint suppression 0 0 0
Electron webPreferences risk 0 0 0

Repo dashboard

main (8f4a5db) #97 (7e537da) +/-
TODO/FIXME 0 0 0
Type escape 1 1 0
Lint suppression 30 30 0
Electron webPreferences risk 0 0 0

Reported by gh-counter

@github-actions

Copy link
Copy Markdown

Code Metrics Report

main (8f4a5db) #97 (7e537da) +/-
Coverage 47.4% 47.6% +0.2%
Code to Test Ratio 1:0.3 1:0.3 -0.1
Test Execution Time 7s 6s -1s
Details
  |                     | main (8f4a5db) | #97 (7e537da) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          47.4% |         47.6% | +0.2% |
  |   Files             |            152 |           152 |     0 |
  |   Lines             |           2707 |          2720 |   +13 |
+ |   Covered           |           1284 |          1296 |   +12 |
- | Code to Test Ratio  |          1:0.3 |         1:0.3 |  -0.1 |
  |   Code              |          14733 |         14767 |   +34 |
  |   Test              |           5061 |          5061 |     0 |
+ | Test Execution Time |             7s |            6s |   -1s |

Code coverage of files in pull request scope (26.2% → 30.0%)

Files Coverage +/- Status
main-src/libs/app-management/install-app-async/install-app-async-core.ts 95.7% -0.8% modified
main-src/libs/app-management/install-app-async/install-app-forked-lite.ts 0.0% 0.0% modified

Reported by octocov

@kitsuyui
kitsuyui merged commit 7aa1b35 into main Aug 16, 2026
6 checks passed
@kitsuyui
kitsuyui deleted the fix/audit-resource-lifecycle-audit-002 branch August 16, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant