feat(result): lock header column of Result window as a winbar when scrolling vertically#218
Open
eduardofuncao wants to merge 2 commits into
Open
feat(result): lock header column of Result window as a winbar when scrolling vertically#218eduardofuncao wants to merge 2 commits into
eduardofuncao wants to merge 2 commits into
Conversation
…, relativenumber, signcolumn and foldcolumn)
eduardofuncao
changed the title
phdah
reviewed
Jul 8, 2025
phdah
left a comment
phdah
left a comment
Contributor
There was a problem hiding this comment.
From the gif, it looks just as you would want it, great job!
With just looking from my phone on the code, I think it looks good. Would you have time to look over it @MattiasMTS ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When scrolling vertically through the result buffer, the column names is not always visible and may confuse the user when trying to get information from the table
What was done
Added the option result.lock_header (false by default) to enable or disable locking the first column of the result buffer on the winbar when scrolling vertically past the first line. When the scroll goes back to the first line, the default winbar of the result window is displayed.
Untitled.Project.mp4
For the horizontal alignment of what is displayed on the winbar with the buffer, we take into account some set options like number, relativenumber, signcolumn, and foldcolumn.
Closes #217