Skip to content

Add otpauth uri - #25

Open
comuttun wants to merge 1 commit into
kwart:masterfrom
comuttun:add_otpauth_uri
Open

Add otpauth uri#25
comuttun wants to merge 1 commit into
kwart:masterfrom
comuttun:add_otpauth_uri

Conversation

@comuttun

Copy link
Copy Markdown

Implemented otpauth URI parse method

@comuttun
comuttun force-pushed the add_otpauth_uri branch 2 times, most recently from 07676bf to 8dfc05d Compare March 29, 2015 02:14
@kwart

kwart commented Apr 1, 2015

Copy link
Copy Markdown
Owner

Hi comutt,
thank you for the contribution. I think it's a nice feature.
Nevertheless I see some problems in the current implementation:

  • if the users choose the otpauth: based profile, and they want to review the options, then the URI field is empty (end there is even no back button)
  • users see the key-generator in the menu even if they use an otpauth: based profile
  • after application restart and going to an otpauth: based profile and choose Options from the menu, users will see empty options page
  • if users has profiles with both otpauth: and manual mode, and they switch between them, then the Options form behaves strange (sometime it's empty, sometime there are options from manualmode used for otpauth profile...)

Have a look at he mentioned problems and update the PR once fixed, please.

@kwart kwart added the needsfix label Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants