Review-surface polish: window chrome, review-exit guard, theming, code blocks (attn-rd3j)

[angusbezzina]

Fixes nine reported defects in the native app, tracked as epic attn-rd3j (10 child issues, all closed).

Three of the nine shared a single root cause and two were misdiagnosed until measured, so this is organised by what was actually wrong rather than by the original list.

base.css typed the whole page, not the document

Bare p / h1 / ul / li selectors applied everywhere, so app chrome inherited reading-surface margins and the document's custom checkbox rule drew a checkmark pinned at left: 0 inside the Share dialog. The reported "weird modal checkmark" was never an element in ShareDialog — it was the leak. Typography is now scoped to .attn-doc, and the .attn-chrome opt-out class that existed purely to undo the leak is deleted along with its six consumers.

The bullets were a faked absolutely-positioned ::before dot with no list-style fallback, so they disappeared entirely whenever the positioning context shifted — exactly the reported symptom. They are real ::marker glyphs now, which cannot detach from their line.

The table "rail" was 13px of stolen layout

base.css styles ::-webkit-scrollbar globally, and in WKWebView styling it at all downgrades that element from macOS overlay scrollbars to classic space-reserving ones. That reserved gutter, painted with an always-on thumb, is the rail. Measured alternatives:

approach	reserved
current (scrollbar-width: thin)	13px
scrollbar-width: auto	17px
webkit revert	17px
hidden	0px

Nothing restores overlay behaviour, so prose blocks hide the bar and scroll by trackpad — the treatment PathBreadcrumb already used. The rules must sit outside @layer components, because base.css's scrollbar rules are deliberately unlayered and unlayered beats layered; the first attempt silently lost the cascade.

Review-exit membership came from the wrong set

ownerRoomForPath resolves a file to a room through the share root, which for a multi-file share is the whole project — so every file "belonged" to the review and the new guard never fired. Added roomPublishesPath, which answers from published snapshots and reconciles relative snapshot paths (alpha.md) against absolute nav paths.

The same confusion is fixed in the owner auto-follow effect, which was re-selecting the room immediately after an explicit exit and putting review chrome on files that were never shared. It now does what its own docstring already claimed.

Important

Behaviour change worth a look: opening an unshared file in a shared project now turns collaboration chrome off, rather than leaving the chip and rail on. I read that as the intended semantics, but it is the one change here that is not purely additive.

Syntax highlighting was never a Rust concern

src/markdown.rs renders no HTML and comrak's syntect feature is off by design — client-side shiki is the intended architecture and is standard practice. The real gaps were a hardcoded 20-language allowlist that silently dropped everything else, and untagged fences getting zero decorations. Languages now resolve against shiki's full 332-language bundle with on-demand loading (20 preloaded so first paint is instant) plus alias resolution, and untagged fences get conservative content-based detection — confident-match-or-nothing, with JSON verified by actually parsing it and ambiguous blocks left plain. Detected languages are labelled distinctly from author-declared ones.

The rest

• Hidden titlebar — new zoom_window IPC; double-click zooms and restores, attached to every existing drag surface, sharing dragWindow's interactive-element exclusion.
• Code copy button — was appended inside the horizontal scroller, so it slid away. Moved onto a non-scrolling frame, along with the language label, which had the same defect.
• Scrollbars in chrome — dialog bodies, the project-switcher dropdown and the Share dialog's lists route through the shared ScrollArea (measured: 0px reserved, vs 13px native).
• Appearance — three-state Paper / Ink / System, durable in a new prefs.json and stamped into the page before the bundle loads, so launching never shows a frame of the wrong theme.
• Typeset presets — Editorial / Modern / Compact per shadcn's typeset model, in a new Settings dialog reachable from the command palette. Editorial declares no overrides, so the default cannot drift.

Verification

Driven against the running app, not just the test suite:

• double-click zoomed 960×720 → 1512×887 → back; double-clicking a button did not zoom
• copy button moved 0px while content scrolled 106px
• reserved scrollbar space 13px → 0 on every overflowing block
• exit prompt fires, cancel preserves, confirm tears down cleanly, re-entering re-activates
• system → dark resolved on a dark-mode Mac; a manual Paper choice survived a daemon restart

That pass caught a defect of its own: the selected Appearance segment used bg-background over bg-muted/30 and was invisible in dark mode.

97 web test files and 1207 Rust tests pass (17 new unit tests). test-e2e.sh and test-review-e2e.sh are byte-identical to the pre-change baseline — confirmed by stashing and re-running, so their failures are pre-existing, not introduced here. Release binary 32.09 / 40 MiB.

Also included

.beads/embeddeddolt/ (58 MB of local Dolt state) was untracked but not ignored — added to .beads/.gitignore so it cannot be committed by accident.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
attn	Ready	Preview	Aug 4, 2026 6:08pm