README.md: Require nvme-cli >= 3.0 - #263
Open
Mr-Bossman wants to merge 1 commit into
Open
Conversation
Commit df7cf50 ("nvme: rely on nvme-cli status code") changed nvme-cli to use the exit code to determine the result of the command, which is only available in nvme-cli >= 3.0. This commit updates the readme to match this requirement. Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
Contributor
|
nvme-cli 2.16 also returns error codes, there is no hard dependency on 3.0. |
Collaborator
|
Thanks for this PR, but I have the same view as @igaw . Quite a few blktests users will keep on running blktests with nvme-cli older than 3.0, and I do not want to upset them. For that purpose, blktests should work with the older nvme-cli. If you see any failure with older nvme-cli versions, report will be appreciated. |
Contributor
Author
Yes let me see if i can make a simple example. The gist is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit df7cf50 ("nvme: rely on nvme-cli status code") changed nvme-cli to use the exit code to determine the result of the command, which is only available in nvme-cli >= 3.0. This commit updates the readme to match this requirement.