Use canonical no-op span context for Expo compatibility - #1452
Merged
schickling-assistant merged 1 commit intoJul 25, 2026
Merged
Conversation
Contributor
PR preview
Report historyPR 1452 · 2026-07-25 22:31 UTC
PR 1452 · 2026-07-19 18:43 UTC
PR 1452 · 2026-07-18 12:53 UTC
|
schickling-assistant
force-pushed
the
schickling-assistant/fix/nooptracer-relative-import
branch
from
July 19, 2026 18:18
7715185 to
d52c6db
Compare
schickling-assistant
changed the title
schickling-assistant
marked this pull request as ready for review
July 25, 2026 21:49
schickling-assistant
force-pushed
the
schickling-assistant/fix/nooptracer-relative-import
branch
from
July 25, 2026 21:49
d52c6db to
73a6b66
Compare
schickling-assistant
deleted the
schickling-assistant/fix/nooptracer-relative-import
branch
July 25, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expo Metro cannot resolve
NoopTracer's package self-import while bundling LiveStore workspace source. The imported CUID also fabricated trace/span identifiers that are invalid under OpenTelemetry's identifier contract.What
INVALID_SPAN_CONTEXTfrom no-op spans.NoopTracerinstead of changing the browser CUID implementation.startActiveSpanoverloads.Rationale
OpenTelemetry's own
NonRecordingSpandefaults toINVALID_SPAN_CONTEXT. A no-op span should not synthesize trace identity, and removing that dependency resolves the Metro source-link failure at its source without broadening the change into CUID runtime behavior.Verification
pnpm --filter @livestore/utils exec vitest run src/NoopTracer.test.tspnpm --filter @livestore/utils exec tsc --noEmit -p tsconfig.jsonPosted on behalf of @schickling
agent_nameagent_session_idagent_toolagent_tool_versionagent_runtimeagent_modelruntime_profileskills_manifestworktreemachinetooling_profile