fix(agent): tolerate explicit null for list fields in streamed events - #573
Merged
Conversation
Following the same class of bug as the `null` `outputs` fix: several
list-typed fields on the streamed conversation event payloads were
`#[serde(default)]`, which only covers a missing key — not an explicit
`null`. An event carrying e.g. `"tip_chips": null` failed to deserialize
and aborted the whole event stream:
invalid type: null, expected a sequence
Deserialize `tip_chips` (node/subagent/agent-tool `*_started` payloads),
`WorkflowFinishedPayload.process_data`, and `SubagentStartedPayload.tools`
through `null_as_default` so `null` maps to an empty list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
nulloutputsfix (#572), same class of bug.Several list-typed fields on the streamed AI Agent conversation event payloads were
#[serde(default)], which only fills a missing key — it does not accept an explicitnull. An event carrying e.g."tip_chips": nullfailed to deserialize and aborted the whole event stream:Fixed by deserializing these through
serde_utils::null_as_defaultsonullmaps to an empty list:tip_chips— on the node / subagent / agent-tool*_startedpayloadsWorkflowFinishedPayload.process_dataSubagentStartedPayload.toolsAdded a unit test covering
nullfor each.