`Development`: Keep evaluation working after a professor leaves and add a supervisor filter by az108 · Pull Request #2446 · ls1intum/doc-apply

az108 · 2026-05-03T10:41:36Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with very good performance and prevented unnecessary or complex database calls.
I strictly followed the server coding and design guidelines.
I documented the Java code using JavaDoc style.

Client

I strictly followed the client coding and design guidelines.

Motivation and Context

Three issues on the research-group view for professors / employees, bundled here. Closes #2445.

Bug — Evaluation page crashed when an application's job had a professor that no longer had a research group (the user-retention job anonymises the supervising professor to a sentinel "deleted user" without a research group). `ProfessorDTO.fromEntity` threw `IllegalStateException`, and applications referencing that job stopped loading even though the job and applications are still part of the research group.
Already correct — `/api/jobs/research-group` already returns every job whose research group matches the current member's, so each professor sees the whole group's pipeline. No code change.
Filter — `my-positions` (job management) had only a status filter. Added a supervisor multi-select so a professor can filter to their own jobs (or to any other colleague's).

Description

1. Bug fix

New `ProfessorDTO.fromJob(Job)` factory uses `job.getResearchGroup()` as the source of truth — the research group is preserved on the Job even after the supervising professor is anonymised.
Made `ProfessorDTO.fromEntity(User)` graceful (returns null research-group fields instead of throwing) for any future caller without a Job in hand.
`ApplicationEvaluationDetailDTO.fromApplication` and `InterviewBookingService` switched to `fromJob`.

2. Supervisor filter

`ProfessorJobsFilterDTO` gained `List supervisorIds`.
`JobRepository.findAllJobsByResearchGroup` query and `JobService.getJobsForCurrentResearchGroup` thread the new param. Null/empty → no filter.
`my-positions-page` fetches the research group's professors via the existing `/api/research-groups/professors` endpoint on init and populates a `supervisor` filter alongside the existing `status` filter. Selected names are mapped back to user ids before the API call.
New i18n keys: `myPositionsPage.searchFilterSortBar.filterOptions.supervisor` (+ `supervisorSearchPlaceholder`) in EN + DE.
OpenAPI yaml updated, TS client regenerated and force-added.

Steps for Testing

Prerequisites:

As an admin, add two professors (A and B) to the same research group.
Both professors create at least one job each, and have at least one submitted application on each of their jobs.
Sign in as professor A and remove professor B from the research group.
Open the evaluation page for one of professor B's applications — it should load and render the application detail without errors (the bug case: the original supervising professor is gone, but the job + applications still belong to the research group).
Open Recruitment > My Positions as professor A — the table should list every job in the research group, including the ones professor B created before being removed.
Open the new Supervisor filter, pick yourself (professor A) — only A's jobs remain. Clear and pick professor B — only B's (now-orphaned) jobs remain.
`./gradlew test --tests "JobResourceTest" --tests "ApplicationEvaluation" --tests "InterviewBooking"` — green.

Screenshots

Adding screenshots.

… add a supervisor filter Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

codacy-production · 2026-05-03T10:42:29Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity

Metric Results

Complexity 4

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-05-03T10:44:57Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

…ettier Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-03T12:15:42Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-03T18:03:26Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-11T12:57:11Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-05-19T21:08:05Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-27T13:06:06Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-06-04T13:00:58Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-06-21T12:38:19Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-02T12:38:17Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

…obs-and-evaluation-cleanup # Conflicts: # src/main/java/de/tum/cit/aet/usermanagement/dto/ProfessorDTO.java # src/main/webapp/app/job/my-positions/my-positions-page.component.ts

codacy-production · 2026-07-05T09:36:55Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity

Metric Results

Complexity 5

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-07-05T09:43:08Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-07-14T12:26:17Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-17T23:31:50Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-07-25T12:18:34Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-28T18:19:13Z

🤖 No OpenAPI or client changes needed.

\Development\: Keep evaluation working after a professor leaves and…

e736958

… add a supervisor filter Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions Bot assigned az108 May 3, 2026

az108 added the ready for review label May 3, 2026

\Bugfix\: Update my-positions test for supervisor filter and run pr…

ed0bbb4

…ettier Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions Bot added the tests label May 3, 2026

Merge branch 'main' into feat/research-group-jobs-and-evaluation-cleanup

ea17e01

github-actions Bot added stale and removed ready for review labels May 11, 2026

Merge branch 'main' into feat/research-group-jobs-and-evaluation-cleanup

11d337c

az108 removed the stale label May 19, 2026

az108 added the ready for review label May 19, 2026

github-actions Bot added stale and removed ready for review labels May 27, 2026

az108 added ready for review and removed stale labels May 28, 2026

github-actions Bot added stale and removed ready for review labels Jun 4, 2026

az108 added ready for review and removed stale labels Jun 13, 2026

github-actions Bot added stale and removed ready for review labels Jun 21, 2026

az108 added ready for review and removed stale labels Jun 22, 2026

github-actions Bot added stale and removed ready for review labels Jul 2, 2026

Cathy0123456789 removed the stale label Jul 3, 2026

az108 added the ready for review label Jul 4, 2026

Merge remote-tracking branch 'origin/main' into feat/research-group-j…

8f72ed5

…obs-and-evaluation-cleanup # Conflicts: # src/main/java/de/tum/cit/aet/usermanagement/dto/ProfessorDTO.java # src/main/webapp/app/job/my-positions/my-positions-page.component.ts

github-actions Bot removed the evaluation Code changes in evaluation module. label Jul 5, 2026

github-actions Bot added stale and removed ready for review labels Jul 14, 2026

az108 added ready for review and removed stale labels Jul 16, 2026

Merge branch 'main' into feat/research-group-jobs-and-evaluation-cleanup

bb25711

github-actions Bot added stale and removed ready for review labels Jul 25, 2026

az108 added ready for review and removed stale labels Jul 25, 2026

Merge branch 'main' into feat/research-group-jobs-and-evaluation-cleanup

32d26e2

Uh oh!

Conversation

az108 commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Screenshots

Uh oh!

codacy-production Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

codacy-production Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

az108 commented May 3, 2026 •

edited

Loading

codacy-production Bot commented May 3, 2026 •

edited

Loading

codacy-production Bot commented Jul 5, 2026 •

edited

Loading