`Development`: Reuse compliance analysis across languages via snippet mapping by ge94zec · Pull Request #2470 · ls1intum/doc-apply

ge94zec · 2026-05-05T08:01:48Z

added endpoint POST that maps source issues to a target language
added prompt that returns one mapped text snippet per line in source complianceIssues order, other fields carry over
wired compliance mapping through client → server API
separated compliance analysis from score calculation
extracted save flow in JobService into Consumer
improved performance by eliminating redundant analysis steps in job creation

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.

Motivation and Context

Closes: #2346

Description

This change improves the bilingual AI compliance workflow for job descriptions by replacing the second target-language compliance analysis with a snippet mapping. The editor now analyzes the source language once in analyzeJobDescription, streams and stores the translated text in translateTextStream, and then maps the detected compliance snippets onto the translated version automatically mapComplianceIssues. This reduces duplicate AI work, keeps translated highlights in sync with sourceIssues.

The duplicated compliance issue persistence logic in JobService was extracted into a shared helper. Since the Score is currently a combined value derived from both gender and legal analysis, this ensures the score remains consistent and is only updated when a full, valid recalculation is possible.

LLM compliance calls per autosave cycle is now reduced from 2 to 1. The translation with second analysis is reduced from 11s to approximately 2.30s.

Steps for Testing

Prerequisites:

Log in to TUMApply as Prof
Nav to Create position
Verify that the complianceAnalysis of target stays within a 2-second threshold

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Screenshots

Test Coverage

Client

Class/File	Line Coverage	Lines	Expects	Ratio
job-creation-form.component.ts	72.64%	1285	96	7.5

Server

Class/File	Line Coverage	Lines
MapComplianceIssuesRequestDTO.java	100.00%	15
AiService.java	32.89%	390
AiResource.java	48.15%	99
JobService.java	72.88%	385

Last updated: 2026-08-01 20:46:33 UTC

…rget text - added endpoint POST that maps source issues to a target language - added prompt that returns one mapped text snippet per line in source complianceIssues order, other fields carry over - wired compliance mapping through client → server API - separated compliance analysis from score calculation - extracted save flow in JobService into Consumer - improved performance by eliminating redundant analysis steps in job creation

codacy-production · 2026-05-05T08:03:11Z

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results

Complexity 1 medium

View in Codacy

🟢 Metrics 8 complexity

Metric Results

Complexity 8

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-05-05T08:03:56Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-05T08:11:29Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-05T08:11:50Z

🤖 No OpenAPI or client changes needed.

- updated openapi - added comment to AiService - simplified AiService mapping - updated prompt

github-actions · 2026-05-05T17:10:41Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-05T17:11:04Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-05-05T17:11:11Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-08T23:39:26Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-08T23:39:39Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-08T23:40:20Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

- make job authorization check reusable in JobService - check job access before mapping compliance issues - Clear target-language issues in DB when source list is empty - skip target mapping when source analysis was skipped/failed

…or-compliance' into chore/2346-enhance-performance-for-compliance

github-actions · 2026-05-09T00:42:04Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-09T00:42:34Z

🤖 No OpenAPI or client changes needed.

codacy-production · 2026-05-09T14:06:39Z

Not up to standards ⛔

🔴 Issues 3 medium

Alerts:
⚠ 3 issues (≤ 0 issues of at least minor severity)

Results:
3 new issues

Category Results

Complexity 3 medium

View in Codacy

🟢 Metrics 10 complexity

Metric Results

Complexity 10

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-05-09T14:08:13Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-05-09T14:08:50Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-14T17:37:08Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-22T12:46:47Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-06-10T14:46:21Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-06-10T14:47:08Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-06-18T13:07:02Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-11T12:17:30Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

# Conflicts: # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

github-actions · 2026-08-01T20:13:14Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-08-01T20:15:36Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-08-01T20:15:50Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

pnpm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

…nslated descriptions - remove the second compliance analysis for the translated description - reuse source-language compliance issues for snippet mapping - update target-language highlights from mapped issues

codacy-production · 2026-08-01T20:33:42Z

Not up to standards ⛔

🔴 Issues 1 high · 1 medium

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results

Security 1 high

Complexity 1 medium

View in Codacy

🟢 Metrics 37 complexity

Metric Results

Complexity 37

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-08-01T20:34:35Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-08-01T20:35:08Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-08-01T20:43:11Z

🤖 No OpenAPI or client changes needed.

ge94zec linked an issue May 5, 2026 that may be closed by this pull request

Enhance performance for compliance #2346

Open

github-actions Bot assigned ge94zec May 5, 2026

github-actions Bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) job Code changes in job module. labels May 5, 2026

updated openapi

9adc3e9

ge94zec changed the title ~~Chore: Reuse compliance analysis across languages via snippet mapping~~ Development: Reuse compliance analysis across languages via snippet mapping May 5, 2026

refactor: code

7946480

- updated openapi - added comment to AiService - simplified AiService mapping - updated prompt

github-actions Bot added the tests label May 5, 2026

ge94zec changed the title ~~Development: Reuse compliance analysis across languages via snippet mapping~~ Development: Reuse compliance analysis across languages via snippet mapping May 5, 2026

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

7433eeb

ge94zec added 2 commits May 9, 2026 02:39

updates:

5579180

- make job authorization check reusable in JobService - check job access before mapping compliance issues - Clear target-language issues in DB when source list is empty - skip target mapping when source analysis was skipped/failed

Merge remote-tracking branch 'origin/chore/2346-enhance-performance-f…

97f4653

…or-compliance' into chore/2346-enhance-performance-for-compliance

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

bd80f96

helios-aet Bot had a problem deploying to test-server May 14, 2026 17:31 Failure

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

630a36f

helios-aet Bot temporarily deployed to test-server May 14, 2026 18:13 Inactive

github-actions Bot added the stale label May 22, 2026

github-actions Bot closed this Jun 5, 2026

ge94zec removed the stale label Jun 10, 2026

ge94zec reopened this Jun 10, 2026

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

ba210c9

github-actions Bot added the stale label Jun 18, 2026

Cathy0123456789 removed the stale label Jul 3, 2026

github-actions Bot added the stale label Jul 11, 2026

github-actions Bot closed this Jul 25, 2026

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

a035c0d

# Conflicts: # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

ge94zec reopened this Aug 1, 2026

feat: replace second compliance analysis with snippet mapping for tra…

71a0b76

…nslated descriptions - remove the second compliance analysis for the translated description - reuse source-language compliance issues for snippet mapping - update target-language highlights from mapped issues

ffix server test

8820354

github-actions Bot removed the stale label Aug 2, 2026

Uh oh!

Conversation

ge94zec commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Screenshots

Test Coverage

Client

Server

Uh oh!

codacy-production Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

codacy-production Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

codacy-production Bot commented Aug 1, 2026

Not up to standards ⛔

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

ge94zec commented May 5, 2026 •

edited by github-actions Bot

Loading

codacy-production Bot commented May 5, 2026 •

edited

Loading

codacy-production Bot commented May 9, 2026 •

edited

Loading