`Development`: Allow applicants to unsubmit a submitted application by az108 · Pull Request #2515 · ls1intum/doc-apply

az108 · 2026-05-14T13:58:04Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.
I added multiple server tests (JUnit) related to the features.
I documented the Java code using JavaDoc style.

Client

I strictly followed the client coding and design guidelines.

Motivation and Context

Closes #1523, implementing the issue's Option B / "Forgiving" approach.

Today, "Withdraw" is irreversible: once an applicant clicks it the application moves to a terminal WITHDRAWN state and the server refuses to let them apply to the same position again. Issue #1523 observed that applicants treat Withdraw as an "Undo" button (typically to fix a typo and resubmit), so the current design silently disqualifies users who were trying to correct their submission.

Option B: turn Withdraw into Unsubmit — a revertible action that puts the application back to SAVED (draft), as long as the job's deadline has not passed. The applicant can then edit and resubmit.

Description

Server

ApplicationService.withdrawApplication (src/main/java/de/tum/cit/aet/application/service/ApplicationService.java):
- Refuses any application not currently in SENT (throws OperationNotAllowedException).
- Refuses when the job's endDate is in the past.
- Sets state to SAVED instead of WITHDRAWN.
- Stops sending the APPLICATION_WITHDRAWN email — the action is now "undo submission", not a permanent goodbye.
Endpoint path (PUT /api/applications/withdraw/{id}) and Java method name are unchanged, so no OpenAPI regen / generated-client churn is needed. The user-facing terminology rename is what the issue asked for; renaming the internal API is out of scope.
Server tests cover the four meaningful cases: SENT → revert OK, post-deadline rejected, non-SENT state rejected, unauthorised still 403.

Client

"Withdraw" button is now labelled "Unsubmit" / "Einreichung zurücknehmen" in both detail and overview pages. Eligibility tightened from [SENT, IN_REVIEW] to SENT only, so once a professor starts reviewing the action disappears and the applicant can't accidentally yank an in-progress evaluation back.
Confirmation dialog text rewritten to explain the new semantics: "This will move your application back to draft. The professor will no longer see it, and you can edit and resubmit it before the job's deadline."
Success and error toast strings rewritten accordingly. The "could not unsubmit" toast doubles as the user-facing surface for the deadline check (since the client doesn't currently have the job's endDate available — relying on the server reject + a friendly error message keeps the diff small; a follow-up could add endDate to JobCardDTO and hide the button entirely past the deadline).

Email

The APPLICATION_WITHDRAWN email type is no longer dispatched. The enum value and template files are left in place so nothing else has to move; they simply stop being used.

Non-goals (deliberately out of scope)

Renaming the HTTP endpoint or the Java method.
Removing the WITHDRAWN enum value from ApplicationState.
Deleting APPLICATION_WITHDRAWN.html and APPLICATION_WITHDRAWN_subject.html template files.
Migrating existing WITHDRAWN rows (prod DB is wiped per current state; nothing to migrate).
Adding endDate to client-visible DTOs so the Unsubmit button can be hidden past the deadline (server still enforces correctness; this is a follow-up UX polish).

Steps for Testing

Prerequisites:

Log in as an applicant.
Submit an application to a published job whose deadline is in the future.

Test (happy path):

On the application detail page, open the menu — verify the action reads "Unsubmit" (DE: "Einreichung zurücknehmen").
Click it. The confirmation dialog should explain the application will move back to draft and that you can resubmit before the deadline.
Confirm. Verify a success toast appears ("Application moved back to draft"), the application's state badge flips to draft, and the menu now exposes "Edit" / "Delete" again.
Edit and resubmit the application — confirm it lands back in SENT.

Test (state guard):

Log in as a professor, open the applicant's submitted application, and move it to IN_REVIEW (rate it / open it). As the applicant, refresh the detail page — the "Unsubmit" action should no longer appear.

Test (deadline guard):

Have an admin set a published job's end date to yesterday. As an applicant with a SENT application against that job, click "Unsubmit". Verify the error toast appears ("Couldn't move back to draft / The deadline may have passed") and the application remains in SENT.

Repeat steps 1–6 on the application overview list page (where the same action lives in the row menu).

Review Progress

Code Review

Code Review 1

Manual Tests

Happy path: unsubmit → draft → edit → resubmit
State guard: button hidden once IN_REVIEW
Deadline guard: server rejects + friendly error toast
Both detail and overview pages

Test Coverage

Client

Class/File	Line Coverage	Lines	Expects	Ratio
application-creation-form.component.ts	90.69%	748	123	16.4
application-detail-for-applicant.component.ts	2.87%	349	37	10.6
application-overview-for-applicant.component.ts	0.00%	207	23	11.1

Server

Class/File	Line Coverage	Lines
ApplicationService.java	78.48%	481
ReferenceRequestService.java	97.36%	413

Last updated: 2026-07-28 18:18:24 UTC

Replace the irreversible "Withdraw" action on submitted applications with a forgiving "Unsubmit" that reverts the application to draft, provided the job deadline has not passed. Applicants who clicked Withdraw to fix a typo would previously lock themselves out of re-applying; with this change they can edit and resubmit until the deadline. - ApplicationService.withdrawApplication now sets the state back to SAVED instead of WITHDRAWN, refuses any state other than SENT, and refuses after the job's endDate has passed. No withdrawal email is sent. - UI button + dialog + toast text changed across EN/DE; eligibility is restricted to SENT so the action is hidden once a professor starts a review. - Endpoint path and Java method name kept as "withdraw" to avoid a client/OpenAPI rename; the user-facing terminology change is what issue #1523 asked for. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

codacy-production · 2026-05-14T13:59:03Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

…plication # Conflicts: # src/main/webapp/i18n/en/button.json

github-actions · 2026-05-16T14:28:06Z

🤖 No OpenAPI or client changes needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-19T21:34:30Z

🤖 No OpenAPI or client changes needed.

Stray entry from a merge conflict — nothing references `button.update`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-20T14:39:34Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-20T14:43:11Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-20T14:44:16Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

Resolved conflicts in i18n/de/global.json and i18n/en/global.json for the errorWithdrawingApplication toast; kept the unsubmit-specific deadline message added on this branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-21T17:49:31Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-05-29T13:02:50Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-06-10T13:06:49Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-01T12:59:58Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

codacy-production · 2026-07-05T09:30:31Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 13 complexity

Metric Results

Complexity 13

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-07-05T09:35:47Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-07-13T12:47:55Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

github-actions · 2026-07-13T19:57:27Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-07-17T23:29:39Z

🤖 No OpenAPI or client changes needed.

Resolve the conflict in ApplicationService#withdrawApplication, where this branch and main changed the same method in incompatible ways: - this branch repurposes it from "withdraw" to "unsubmit" (SENT -> SAVED, deadline guard, no email) - main added reference-request cancellation plus a withdrawal email to the old withdraw behaviour Kept this branch's unsubmit semantics, since the feature intentionally replaces withdrawal with a reversible move back to draft. Main's cancellation is deliberately not carried into the unsubmit flow: it flips pending requests to CANCELLED, but dispatchInvitations only re-invites entries that are ADDED with no token, so those referees would never be re-invited on resubmit. An applicant unsubmitting to fix a typo would lose their reference requests for good, after referees were told the letter was no longer needed. With withdrawal gone, cancelPendingForWithdrawnApplication and its sendCancellationEmail helper had no remaining caller and were removed, along with the WithdrawCancellation tests covering them. ReferenceRequestStatus CANCELLED and EmailType REFERENCE_LETTER_CANCELLED are kept: both are still part of the API contract and rendered by the client and PDF export. Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-07-25T11:59:31Z

🤖 No OpenAPI or client changes needed.

…flow Reinstates cancelPendingForWithdrawnApplication and sendCancellationEmail together with their tests, and calls the cancellation again from the unsubmit flow. Both files are byte-identical to main again, so the feature is back exactly as it was written. Removing it here was the wrong call. The reasoning at the time only weighed the applicant who unsubmits and resubmits shortly after; it did not account for the applicant who never resubmits, whose referees would then never hear anything. One consequence is still open and needs a decision rather than a guess. dispatchInvitations only re-invites entries that are ADDED with no token, while cancelling leaves the entry CANCELLED with its token set, so a referee cancelled by an unsubmit is not invited again if the application is resubmitted. Separately, findReminderCandidates filters on request status alone and never looks at the application state, so referees attached to an application sitting in draft keep receiving reminders. Both are recorded here so the follow-up decision is made deliberately. Verified: 786 server tests pass, including the two restored cancellation tests. Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-07-25T16:21:16Z

🤖 No OpenAPI or client changes needed.

… submitted again Settles the withdraw behaviour discussed in review. There is one button, called Withdraw, available while the application is still SENT and therefore not once it is in review. It puts the application back into draft and cancels the pending reference requests, which is what makes the links already emailed to the recommenders stop working. Submitting again now sends those recommenders a fresh request. The cancellation and the dead links were already in place. The missing piece was the second submission: dispatchInvitations only issued a token for entries that had never been invited, so a recommender cancelled by a withdrawal was skipped and never heard from us again. It now also re-issues for cancelled entries, with a new token so the pre-withdrawal link stays dead. Recommenders who already submitted, declined or let their link expire are still skipped, so a second submission never asks the same person twice. Naming goes back to Withdraw across the button, dialog and toasts. The wording does not go back with it: the pre-branch text claimed the action could not be undone, which is no longer true, so it now says the application returns to draft, that the existing recommendation links stop working, and that submitting again sends a new request. The submit confirmation warns about that re-invitation when it applies. The component already holds the reference requests, so the check needs no extra request and mirrors the server condition exactly. Its base message also claimed that submitting made further edits impossible, which withdrawing now disproves, so that has been corrected too. Verified: 788 server tests, 2010 client tests, typecheck, eslint with no errors, a11y lint, the production build and prettier. Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-07-25T17:01:34Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-07-28T18:14:37Z

🤖 No OpenAPI or client changes needed.

github-actions Bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) tests application Code changes in application module. labels May 14, 2026

github-actions Bot assigned az108 May 14, 2026

az108 mentioned this pull request May 14, 2026

General: Rewrite global toast error messages with context and guidance #2517

Merged

8 tasks

Merge remote-tracking branch 'origin/main' into feat/1523-unsubmit-ap…

a239fe5

…plication # Conflicts: # src/main/webapp/i18n/en/button.json

az108 added the ready for review label May 19, 2026

General: Add German translation for button.update

31f091f

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Cathy0123456789 requested changes May 20, 2026

View reviewed changes

Comment thread src/main/webapp/i18n/en/button.json Outdated

General: Drop unused button.update i18n key

a7b2d16

Stray entry from a merge conflict — nothing references `button.update`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

az108 requested a review from Cathy0123456789 May 20, 2026 14:38

Merge branch 'main' into feat/1523-unsubmit-application

5accc07

github-actions Bot added stale and removed ready for review labels May 29, 2026

az108 added ready for review and removed stale labels Jun 2, 2026

github-actions Bot added stale and removed ready for review labels Jun 10, 2026

github-actions Bot removed the ready for review label Jun 19, 2026

az108 added ready for review and removed stale labels Jun 22, 2026

github-actions Bot added stale and removed ready for review labels Jul 1, 2026

Cathy0123456789 removed the stale label Jul 3, 2026

az108 added the ready for review label Jul 4, 2026

Merge branch 'main' into feat/1523-unsubmit-application

fa53b7b

github-actions Bot added stale and removed ready for review labels Jul 13, 2026

Cathy0123456789 removed the stale label Jul 13, 2026

Merge branch 'main' into feat/1523-unsubmit-application

3d68f66

az108 added the ready for review label Jul 16, 2026

Merge branch 'main' into feat/1523-unsubmit-application

1cca273

Cathy0123456789 requested changes Jul 25, 2026

View reviewed changes

Comment thread src/main/java/de/tum/cit/aet/reference/service/ReferenceRequestService.java

az108 requested a review from Cathy0123456789 July 25, 2026 16:59

Merge branch 'main' into feat/1523-unsubmit-application

720cec8

Uh oh!

Conversation

az108 commented May 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Test Coverage

Client

Server

Uh oh!

codacy-production Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

codacy-production Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

az108 commented May 14, 2026 •

edited by github-actions Bot

Loading

codacy-production Bot commented May 14, 2026 •

edited

Loading

codacy-production Bot commented Jul 5, 2026 •

edited

Loading