`Development`: Add action buttons in popover for recommendation system by ge94zec · Pull Request #2520 · ls1intum/doc-apply

ge94zec · 2026-05-14T19:43:59Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.

Motivation and Context

Description

Steps for Testing

Prerequisites:

Log in to TUMApply as Prof
Nav to Create Position
Verify the action buttons behave correctly and text is saved across page switches

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Screenshots

Test Coverage

Warning: Some tests failed in the PR check. Coverage may be incomplete. Please check the workflow logs.

Client

Class/File	Line Coverage	Lines	Expects	Ratio
job-creation-form.component.ts	70.51%	1292	96	7.4
editor.component.ts	75.41%	402	28	7.0
ai-compliance-popover.component.ts	47.61%	38	?	?
suggestion-system.component.ts	30.00%	17	?	?

Server

Class/File	Line Coverage	Lines
ComplianceIssue.java	0.00%	27
ComplianceScoreService.java	86.67%	93

Last updated: 2026-08-01 19:42:53 UTC

- show suggestions in the compliance popover - add suggestion actions for replace, add, remove, and dismiss - extend compliance prompt and model with suggestion field - migration suggestions field on liquibase

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

- Refined the compliance suggestion prompt for more accurate/correct output - Added client logic to insert, replace, or remove snippets at the correct index in the editor and persist the change via the form

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

codacy-production · 2026-05-14T19:45:07Z

Not up to standards ⛔

🔴 Issues 3 high · 4 medium

Alerts:
⚠ 7 issues (≤ 0 issues of at least minor severity)

Results:
7 new issues

Category Results

UnusedCode 2 medium

ErrorProne 2 medium

Security 3 high

View in Codacy

🟢 Metrics 11 complexity

Metric Results

Complexity 11

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

- fix popover hidden under sticky footer

…recommendation-system

github-actions · 2026-05-15T01:49:31Z

🤖 No OpenAPI or client changes needed.

- fix popover hidden under sticky footer - code cleanup

github-actions · 2026-05-15T04:12:04Z

🤖 No OpenAPI or client changes needed.

Cathy0123456789

Thank you, small comments on the code

…ns-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

github-actions · 2026-05-24T21:36:46Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-06-02T13:13:58Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

…recommendation-system

github-actions · 2026-06-03T13:30:21Z

🤖 No OpenAPI or client changes needed.

…recommendation-system

github-actions · 2026-06-10T13:13:19Z

🤖 No OpenAPI or client changes needed.

- reduce the compliance popover z-index from 1001 to 50 - close the popover when the page or a nested container is scrolled - remove the unused popover hover signal and handler - replace the hover output with a dedicated close event

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml # src/main/resources/prompts/AnalyzeComplianceText.st # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

github-actions · 2026-08-01T19:39:36Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

pnpm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-08-01T19:39:39Z

🤖 No OpenAPI or client changes needed.

ge94zec added 5 commits May 8, 2026 16:54

feat: add interactive compliance suggestions

941bd88

- show suggestions in the compliance popover - add suggestion actions for replace, add, remove, and dismiss - extend compliance prompt and model with suggestion field - migration suggestions field on liquibase

Merge remote-tracking branch 'origin/main' into feat/2348-add-action-…

b76eb11

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

feat(compliance): apply AI suggestions to job description editor

fedcb06

- Refined the compliance suggestion prompt for more accurate/correct output - Added client logic to insert, replace, or remove snippets at the correct index in the editor and persist the change via the form

Merge remote-tracking branch 'origin/main' into feat/2348-add-action-…

f09b600

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

fix tests

01a92c8

ge94zec linked an issue May 14, 2026 that may be closed by this pull request

Add action buttons in popover for recommendation system #2348

Open

ge94zec changed the title ~~Feat/2348 add action buttons in popover for recommendation system~~ Development: Add action buttons in popover for recommendation system May 14, 2026

ge94zec self-assigned this May 14, 2026

github-actions Bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) tests database labels May 14, 2026

helios-aet Bot temporarily deployed to test-server May 14, 2026 22:41 Inactive

ge94zec and others added 2 commits May 15, 2026 02:58

- make prompt robuster to find all issues at once

589edd1

- fix popover hidden under sticky footer

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

643223b

…recommendation-system

helios-aet Bot temporarily deployed to test-server May 15, 2026 03:18 Inactive

prettier

afe6710

- fix popover hidden under sticky footer - code cleanup

helios-aet Bot temporarily deployed to test-server May 15, 2026 04:31 Inactive

ge94zec added the ready for review label May 15, 2026

ge94zec marked this pull request as ready for review May 15, 2026 07:20

ge94zec requested a review from az108 as a code owner May 15, 2026 07:20

Cathy0123456789 requested changes May 18, 2026

View reviewed changes

az108 requested changes May 18, 2026

View reviewed changes

az108 removed the ready for review label May 21, 2026

helios-aet Bot temporarily deployed to test-server May 24, 2026 21:08 Inactive

Merge remote-tracking branch 'origin' into feat/2348-add-action-butto…

8950a33

…ns-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

helios-aet Bot had a problem deploying to test-server May 24, 2026 22:38 Failure

helios-aet Bot had a problem deploying to test-server May 25, 2026 20:46 Failure

helios-aet Bot temporarily deployed to test-server May 26, 2026 14:14 Inactive

github-actions Bot added the stale label Jun 2, 2026

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

0c89ea9

…recommendation-system

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

e25c8d8

…recommendation-system

github-actions Bot closed this Jun 25, 2026

Fix compliance popover styling and scroll behavior

37077aa

- reduce the compliance popover z-index from 1001 to 50 - close the popover when the page or a nested container is scrolled - remove the unused popover hover signal and handler - replace the hover output with a dedicated close event

ge94zec reopened this Aug 1, 2026

ge94zec added 2 commits August 1, 2026 18:04

fix merge conflict

bfd1434

github-actions Bot removed the stale label Aug 2, 2026

Uh oh!

Conversation

ge94zec commented May 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Screenshots

Test Coverage

Client

Server

Uh oh!

codacy-production Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

Cathy0123456789 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ge94zec commented May 14, 2026 •

edited by github-actions Bot

Loading

codacy-production Bot commented May 14, 2026 •

edited

Loading