chore: pre-release cleanup - #43
Merged
Merged
Conversation
## Changes ### Lint Fixes (9 warnings → 0) - Remove unused imports across packages - Remove useless constructors (ContextProvider, GitHubProvider) - Use node: protocol for Node.js imports (readline) - Remove non-null assertions where possible - Convert JSONRPCHandler class to exported functions (noStaticOnlyClass) - Add biome-ignore for intentional constructor pattern (AdapterRegistry) ### Code Quality - Refactor JSONRPCHandler from static-only class to module functions - Update all imports to use new function-based API - Update tests to use direct function imports - Clean up adapter-registry by removing unused context field ### Files Changed (17) - packages/cli/src/index.ts - packages/core/src/api/index.ts - packages/core/src/context/index.ts - packages/core/src/github/index.ts - packages/core/src/index.ts - packages/core/src/indexer/indexer-edge.test.ts - packages/integrations/src/claude/index.ts - packages/mcp-server/src/adapters/__tests__/github-adapter.test.ts - packages/mcp-server/src/adapters/adapter-registry.ts - packages/mcp-server/src/adapters/types.ts - packages/mcp-server/src/formatters/__tests__/formatters.test.ts - packages/mcp-server/src/index.ts - packages/mcp-server/src/server/mcp-server.ts - packages/mcp-server/src/server/prompts.ts - packages/mcp-server/src/server/protocol/__tests__/jsonrpc.test.ts - packages/mcp-server/src/server/protocol/jsonrpc.ts - packages/mcp-server/src/server/transport/stdio-transport.ts All 812 tests passing.
## Changes ### TODO Items Resolved (3 → 0) 1. **vector/store.ts - Delete operation** - Clarified that delete is not supported (LanceDB limitation) - Updated error message to recommend upsert instead - Added link to LanceDB documentation 2. **github/indexer.ts - Git root resolution** - Removed TODO, documented that process.cwd() is intentional - Works correctly when CLI is run from repo root 3. **pr/index.ts - PrAgent implementation** - Expanded JSDoc with planned capabilities - Added link to tracking issue (#10) - Clarified placeholder status in log messages ### Test Updates - Updated delete test to match new error message All 812 tests passing.
Remove deprecated shebang and source line from pre-commit hook. These lines will fail in husky v10.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Release Cleanup
This PR addresses code quality issues before release.
Changes
1. Fix All Lint Warnings (9 → 0)
node:protocol for Node.js importsJSONRPCHandlerclass to exported functions (biome: noStaticOnlyClass)2. Address TODO Items (3 → 0)
process.cwd()is intentional3. Fix Husky Deprecation Warning
Quality Metrics
Files Changed