Feedback - #1
Open
github-classroom[bot] wants to merge 31 commits into
Open
Conversation
* Delete kafka-messaging directory * Implementing Microservices Architecture * [FEAT] MVN Multimodules: integrate all MS in a single repo * Small fix * FIX Posts serice * very small fix * add .gitignore * [CORS] api gateway * [TEST][Auth] Add unit and integration test * dockerfiles for posts match auth * [CONTAINERIZATION] : dockerize api-gateway and messaging-service * TEST Gitlab Sync * TEST Gitlab Sync * Update README.md * Add GitHub workflows * Update README.md * Allow upload of target folders * Generate target folders * Update .gitignore files * [DEPLOY] deploy to Kubernetes * Update README.md * Update README.md * Update README.md * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update README.md * Update README.md * Update README.md * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update README.md * Update README.md * Update README.md * Update README.md * Update sync-gitlab.yml * [DOCS] add table of content and more content * test sync * test sync2 * Update README.md * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update README.md * Update README.md * [DOCS] add content to report * [DOCS] small modif * [MONITORING] add prometheus & grafana for monitoring * Test GitHub workflow * Update README.md * Update README.md * Update README.md * Update sync-gitlab.yml * Test GitHub workflows * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update README.md * Update README.md * Update sync-gitlab.yml * Update README.md * Update sync-gitlab.yml * Update README.md * Test CI/CD pipeline auto triggering * Test CI with unprotected GitLab branch * Test CI with protected GitLab branch * Test CI with protected GitLab branch * Update README.md * Update README.md * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update sync-gitlab.yml * Update README.md * Update README.md * Update README.md * Update README.md * Update sync-gitlab.yml * Update sync-gitlab.yml * [REFACTOR][API Gateway] Add config for local * [REFACTOR] Rename microservices as convention * [DOCS] Design Patterns, kafka, monitoring, k8s * [Intellij] Intellij things * [MONITORING]: expose prometheus endpoint for each service * [FEAT] Messaging : replace aws kafka broker with embeded kafka * [FIX] API Gateway: move frontend behind the gateway * [FIX] cors: still not fixed --------- Co-authored-by: Mohammed-Yassine BOUMEHDI <myboumehdi.2002@gmail.com> Co-authored-by: Said NAJIM <saidnajim.ma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @MYassineBoum @ilyasabdellaoui @SaidNajim @adnanemandili