Skip to content
This repository was archived by the owner on Mar 25, 2022. It is now read-only.

upgrade mapbox-gl - #87

Open
aclave1 wants to merge 1 commit into
mainfrom
upgrade-mapbox-113
Open

upgrade mapbox-gl#87
aclave1 wants to merge 1 commit into
mainfrom
upgrade-mapbox-113

Conversation

@aclave1

@aclave1 aclave1 commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Upgrades mapbox-gl from 0.53 to 1.13

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2021
andreilee
andreilee suggested changes Jul 27, 2021
View reviewed changes

@andreilee andreilee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow error

@aclave1

aclave1 commented Jul 27, 2021

Copy link
Copy Markdown
Contributor Author

Flow error

I forgot all about this PR, I'll try to get to it soon

@andreilee

andreilee commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Any update soon?

@aclave1

aclave1 commented Sep 8, 2021

Copy link
Copy Markdown
Contributor Author

No update yet

@lucasgonze

lucasgonze commented Jan 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR would fix https://github.com/ospoco/magma-issue-tracker/issues/40

However the breaking change in MapView.js calls for a front end developer.

image

@aclave1

aclave1 commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @lucasgonze

This PR would fix https://github.com/ospoco/magma-issue-tracker/issues/40

However the breaking change in MapView.js calls for a front end developer.

image

Thanks for letting us know about your issue, I can get to this in the next few weeks, I've been really dragging my feet on this one.

@lucasgonze

lucasgonze commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Thanks @lucasgonze

This PR would fix ospoco/magma-issue-tracker#40
However the breaking change in MapView.js calls for a front end developer.
image

Thanks for letting us know about your issue, I can get to this in the next few weeks, I've been really dragging my feet on this one.

FWIW that MapView.js file no longer exists, so this test failure may well be gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andreilee andreilee andreilee requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aclave1 @andreilee @lucasgonze @facebook-github-bot