Migrate docker module to moby - #909
Conversation
Migrate from the deprecated github.com/docker/docker module to the current latest version of github.com/moby/moby, and make all changes necessary to adapt to its refactoring.
| return "", fmt.Errorf("%s: failed to create docker network. %w", blueprintName, err) | ||
| } | ||
| if nw.Warning != "" { | ||
| if len(nw.Warning) > 0 && nw.Warning[0] != "" { |
There was a problem hiding this comment.
wondering why we have to check [0] != "" as well. Is it actually necessary?
I don't mind and I don't know, just seems bizarre to me
There was a problem hiding this comment.
I don't know if it's necessary either, but figured it was cheap to guard against it just in case.
| "time" | ||
|
|
||
| "github.com/docker/docker/api/types/container" | ||
| "github.com/matrix-org/complement/internal/docker" |
There was a problem hiding this comment.
For reference, what's spawning this change? (migrating docker module to moby)
There was a problem hiding this comment.
The fact that docker/docker is no longer getting new releases & has some CVEs that AIUI are fixed only in the replacement moby/ packages.
Granted, CVEs aren't much of an issue for integration tests, but this felt like a good catalyst for doing the migration.
There was a problem hiding this comment.
What made you care about this though?
How did you notice?
There was a problem hiding this comment.
One of our security scanners (Vanta) flagged the CVEs in all of our repos that use Complement.
4 participants
Migrate from the deprecated github.com/docker/docker module to the current latest version of github.com/moby/moby, and make all changes necessary to adapt to its refactoring.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Pull Request Checklist