Skip to content

Scala version - #38

Open
cotonne wants to merge 1 commit into
michelgrootjans:masterfrom
cotonne:master
Open

Scala version#38
cotonne wants to merge 1 commit into
michelgrootjans:masterfrom
cotonne:master

Conversation

@cotonne

@cotonne cotonne commented May 19, 2017

Copy link
Copy Markdown

Hi,

Following the workshop at nCrafts, here is a scala version.
RFC

Regards

Comment thread scala/README.md
@@ -0,0 +1,5 @@
Client requirement : scala 2.12 & sbt 0.13

To build and run : ''' sbt 'run ../data/0.json' '''

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use backticks: ` for code examples in markdown.

@loicknuchel

loicknuchel commented May 24, 2017

Copy link
Copy Markdown
Contributor

Hi, I was working on a Scala version too when I saw your PR (https://github.com/loicknuchel/playing_with_projections/tree/scala-version/scala) ^^

What do you think about providing types instead of JsonElement ?
I would be easier to work with and much more idiomatic for Scala code.
For example, I did : https://github.com/loicknuchel/playing_with_projections/blob/scala-version/scala/src/main/scala/domain/Event.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants