fix: use the cooldown key actions accepts - #99
Conversation
semver-major-days is not supported for the github-actions ecosystem. GitHub rejects it with "not supported for the package ecosystem 'github-actions'", and the rejection is not graceful: an invalid key invalidates the file and drops the whole github-actions entry, grouping and ignore rules included. So a cooldown meant to add a soak period removes the grouping instead. The check-dependabot hook passes on it, because the rejection is server-side rather than schematic, which is how it got merged. A sibling repository had already hit this and recorded the fix in its own config; that comment is where this came from. One number therefore covers every actions update. 30 days rather than something shorter because bot-automerge.yml arms actions majors, so this is the only soak between a release being published and it merging here unattended. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
PR Summary by QodoFix Dependabot cooldown key for github-actions ecosystem
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
There was a problem hiding this comment.
Pull request overview
Updates the Dependabot configuration for the github-actions ecosystem to use a supported cooldown key so that the entire github-actions update entry (including grouping rules) is not silently dropped by GitHub.
Changes:
- Replaces an unsupported
semver-major-dayscooldown key withdefault-daysforgithub-actions. - Increases the cooldown to 30 days to provide a single soak period for all GitHub Actions updates.
- Adds an explanatory comment documenting the server-side validation behavior and why local schema validation doesn’t catch it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review by Qodo
1.
|
The comment described a "30-day major cooldown" in dependabot.yml, which stopped being true in the previous commit: the github-actions ecosystem accepts no major-specific cooldown key, so the delay is default-days and covers every actions update. Left as it was, the one place a reader is told how the arming policy and the cooldown fit together described a key that is not there. Also records that the effective delay is longer than the number, which a review raised and which matters if anyone tunes it: this ecosystem is polled on the 1st and 15th, so an update whose cooldown expires just after a poll waits for the next one. Thirty days of cooldown lands a pull request roughly thirty to forty-five days after the release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Summary
Replaces
semver-major-dayswithdefault-dayson thegithub-actionsecosystem, because that ecosystem does not accept thesemver-*keys and the failure is silent and total rather than partial.GitHub rejects
semver-major-daysforgithub-actionswith "not supported for the package ecosystem 'github-actions'", and the options reference confirms it:default-daysis supported for every package manager, whilesemver-major-days,semver-minor-daysandsemver-patch-daysare supported only for the ecosystems it lists, andgithub-actionsis not among them. An invalid key does not degrade to "cooldown ignored" — it invalidates the file and drops the wholegithub-actionsentry, grouping and ignore rules included. So a key added to introduce a soak period removes the grouping instead, and the visible symptom is one pull request per action rather than one per group.This is a self-inflicted regression and worth saying so plainly: the invalid key arrived in the pull request that standardized this workflow, and it merged because the
check-dependabotpre-commit hook passes on it. That hook validates against the published schema, and the schema admitssemver-major-daysin acooldownblock generally — the ecosystem restriction is enforced server-side, so no local gate can catch it. A sibling repository had already hit this and recorded the diagnosis in its own config; that comment is where this fix came from.One number therefore has to cover every actions update. 30 days rather than something shorter, because
bot-automerge.ymlnow armsgithub-actionsmajors instead of holding them — this delay is the only soak period between a release being published and it merging here unattended. A patch is not safer than a major when the risk is a compromised publisher rather than a changed interface, and these packages execute with this repository's own token inside jobs holding write scopes.A review on this pull request raised two further things, both acted on in a follow-up commit. The workflow comment still described a "30-day major cooldown", which stopped being true the moment the key changed — the one place a reader is told how the arming policy and the cooldown fit together was describing a key that is not there. And the effective delay is longer than the number: this ecosystem is polled on the 1st and 15th, so an update whose cooldown expires just after a poll waits for the next one, putting a pull request roughly 30–45 days after the release rather than 30. That is recorded rather than retuned, because shortening the cooldown to compensate would couple two independent settings and the drift is in the safe direction.
Test plan
github-actionssupportsdefault-daysonlypre-commit run --files .github/dependabot.ymlpasses — noted above as insufficient, and recorded here because passing is exactly what made this reachableactionlintandyamllintclean on the workflow comment changegithub-actionspull request arriving grouped. That cannot be observed before merge, and it is the check to make afterwards: one grouped pull request means the entry is being read, several ungrouped ones mean it is still being dropped.Reviewer guide