fix(helm): add missing hubble metrics port to retina agent daemonset - #2580
Open
ckaytev wants to merge 1 commit into
Open
fix(helm): add missing hubble metrics port to retina agent daemonset#2580ckaytev wants to merge 1 commit into
ckaytev wants to merge 1 commit into
Conversation
Signed-off-by: ckaytev <anton-ckayt@mail.ru>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Prometheus metric scraping for Hubble metrics by adding the missing hubble metrics port to the Retina agent DaemonSet.
Problem
The
network-observabilityService (templates/hubble/metrics-service.yaml) was configured with two ports:hubbleport (default 9965) — for Hubble metricsretinaport (default 10093) — for Retina metricsHowever, the Retina agent DaemonSet (
templates/agent/daemonset.yaml) only exposed a single port (10093). The Hubble metrics server, configured via ConfigMap to listen on port 9965 (hubble-metrics-server: ":9965"), had no correspondingcontainerPortdeclared in the pod spec. This caused Prometheus scrapes to Hubble metrics to fail.Additionally, the
targetPortfor the retina port in the Service used{{ .Values.retinaPort }}instead of{{ .Values.agent.container.retina.ports.containerPort }}, which could cause inconsistency if these values diverge.Changes
templates/agent/daemonset.yaml(Linux & Windows): Added the hubble metrics port ({{ .Values.hubble.metrics.port }}) to the container ports listtemplates/hubble/metrics-service.yaml: FixedtargetPortfor the retina port to use{{ .Values.agent.container.retina.ports.containerPort }}Port Mapping
retina{{ .Values.agent.container.retina.ports.containerPort }}(default: 10093)hubble{{ .Values.hubble.metrics.port }}(default: 9965)retina{{ .Values.retinaPort }}→ targetsretinacontainer porthubble{{ .Values.hubble.metrics.port }}→ targetshubblecontainer port