fix(chart): default agent and operator images to ghcr.io - #2591
Open
darkweaver87 wants to merge 2 commits into
Open
fix(chart): default agent and operator images to ghcr.io#2591darkweaver87 wants to merge 2 commits into
darkweaver87 wants to merge 2 commits into
Conversation
Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
nddq
requested changes
Jul 28, 2026
| repository: acndev.azurecr.io/retina-operator | ||
| repository: ghcr.io/microsoft/retina/retina-operator | ||
| pullPolicy: Always | ||
| tag: "latest" |
Member
There was a problem hiding this comment.
I don't think we've ever published latest tags for any images, we should pin this to a released version tag
Author
There was a problem hiding this comment.
Good catch — done. The three Retina image tags now default to .Chart.Version (the released chart version, e.g. v1.2.3) when left empty, instead of latest; --set <image>.tag=… still overrides. Verified with helm package --version + helm template — which is exactly what release-charts.yaml (L55-56) does, so the published chart's .Chart.Version is the release tag.
… latest Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The retina-hubble chart defaults the agent and operator images to
acndev.azurecr.io, an internal registry that isn't reachable outside Microsoft, so a stockhelm installof the published chart lands inImagePullBackOff. Theretina-initimage, and thestandardchart's agent/operator, already default toghcr.io/microsoft/retina/*; this aligns the hubble chart with them. Only the two default repositories change — rendered output is otherwise identical.