feat(feedback): implement feedback summaries asset and job - #2604
Open
rachellougee wants to merge 4 commits into
Open
feat(feedback): implement feedback summaries asset and job#2604rachellougee wants to merge 4 commits into
rachellougee wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an incremental Dagster asset for LLM-generated feedback conversation summaries, including provider support and PII-redaction improvements.
Changes:
- Adds conversation summarization, skip rules, and incremental processing.
- Adds Bedrock authentication and automation/job configuration.
- Updates PII redaction behavior and unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
ml/resources/llm.py |
Adds Bedrock and local environment authentication. |
ml/lib/summarize.py |
Implements summarization and incremental filtering. |
ml/lib/redact.py |
Adjusts overlapping URL/PII handling. |
ml/definitions.py |
Registers the asset, job, sensor, and resource. |
ml/assets/feedback_summaries.py |
Defines the summaries Dagster asset. |
ml_tests/test_summarize.py |
Tests summary rules and incremental filtering. |
ml_tests/test_redact.py |
Adds URL-overlap regression coverage. |
ml_tests/test_llm.py |
Tests Bedrock client creation and caching. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Close #2542
Description (What does it do?)
Builds the
feedback_summariesDagster assetint__feedback__conversation, calls an LLM to generateconversation_summaryper multi-turn conversationAnthropic,OpenAI, andAWS Bedrockas the LLM backend (needs to confirm with @blarghmatey if Bedrock is configured on production)How can this be tested?
int__feedback__conversationmust exist in your dev schema. If it doesn't, copy it from production:feedback_summarieswith a small sample_limit via Launchpad config:Expected log line:
Summarized 100 new conversations (0 already summarized, 100 total upstream).The sensor is off by default and this is only needed once Bedrock/API access is confirmed working and you want it to run automatically.
Query the output table
Additional Context
For deployment step, do a Full refresh — feedback_redacted to fixes historical mis-redactions: