Create About Page - #125
Draft
UtkarshKr007 wants to merge 22 commits into
Draft
Conversation
Added info icon to sidebar Co-authored-by: Utkarsh Kumar <kumar375@morris.umn.edu>
Co-authored-by: Utkarsh Kumar <kumar375@morris.umn.edu> Co-authored-by: Paul Friederichsen <floogulinc@gmail.com>
The gatsby-source-github-api doesn't support retrieving contributors yet. The closest thing it can give is a list of collaborators which are different, so I used a different plugin. I also filter dependabot out in the GraphQL query. I initally had a regex query that fitlered out any login with "bot" in it, but that could theoretically catch future contributors whose login contain the words 'bot'.
I didn't use the alt prop, because in local testing it didn't show to replace image with first letter of alt vale as material ui docs say it should.
floogulinc
reviewed
Dec 16, 2020
floogulinc
reviewed
Dec 16, 2020
floogulinc
reviewed
Dec 16, 2020
floogulinc
reviewed
Dec 16, 2020
floogulinc
reviewed
Dec 16, 2020
Remove blur on logo Co-authored-by: Paul Friederichsen <floogulinc@gmail.com>
floogulinc
force-pushed
the
about-page
branch
from
December 17, 2020 05:20
c0405a6 to
85815f5
Compare
This reverts commit 85815f5.
floogulinc
requested changes
Dec 21, 2020
floogulinc
left a comment
floogulinc
left a comment
Member
There was a problem hiding this comment.
Looking pretty good, just a few concerns.
Comment on lines
+71
to
+73
| Pollinator Facts website was created alongside the <a href="https://buzzabout.app">Buzz About</a> participatory simulation game to | ||
| teach people about native pollinators of Minnesota. This website holds many interesting tidbits as well beautiful pictures of pollinators, their food, homes | ||
| and habits. |
Member
There was a problem hiding this comment.
We probably want to work on this blurb. I don't know if we want to link to Buzz About here.
Comment on lines
+172
to
+173
| The images used for facts belong to their respective owners. Clicking the info button on the bottom right of a fact | ||
| presents the information and links to the image owners as well as the license under which the image is published. |
Member
There was a problem hiding this comment.
Definitely need to work on this.
GatsbyImage doesn't support SVG format, so we have to import the svg into the about.js file and then use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9 and Closes: #182