Fix protocol version tag for stateless server spans - #1810
Merged
tarekgh merged 4 commits intoAug 14, 2026
Merged
Conversation
Contributor
|
Thanks for submitting this, @luisangelrod! Tagging @tarekgh for review. |
jeffhandley
previously requested changes
Aug 13, 2026
Cover per-request protocol version tagging across multiple versions in stateless mode, assert the negotiated version alongside the tag, and add a stateful test asserting the negotiated version drives the tag.
tarekgh
approved these changes
Aug 13, 2026
tarekgh
left a comment
tarekgh
left a comment
Contributor
There was a problem hiding this comment.
I pushed small test changes, LGTM otherwise.
Thanks @luisangelrod for helping with this fix.
halter73
approved these changes
Aug 13, 2026
tarekgh
dismissed
jeffhandley’s stale review
August 14, 2026 15:40
We addressed the comment and if there is any more follow up we can do it in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1800
Testing