Remove possible "ignore" value from "use_node_name" - #1140
Open
sumpfralle wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
This change set is based upon #1139. |
Pull Request Test Coverage Report for Build 2715
💛 - Coveralls |
Member
|
This is more to cope with none standard nodes that exist out there. |
Collaborator
Author
You mean: implementations of |
Collaborator
Author
|
@steveschnepp: do you see any issues with the removal of this option? |
The setting was introduced in 6adf38a. But somehow it partially lost its meaning in the merge commit c8228b8 (Merge branch 'sql' into devel). Afterwards it was only used for for breaking the node communication in case of a missing "host" attribute (which can never be empty as it is an integral part of the node specification in the master configuration). Thus it is not useful anymore. The purpose of this setting was later replaced with "use_node_name ignore" in dd4cbb5.
The additional value "ignore" was added in dd4cbb5. It caused the following "list" commands to be sent to the node: * "yes" -> "list $self->{node_name}" * "ignore" -> "list " * "no" -> "list $self->{host}" * any other value -> "list $self->{host}" The above "$self->{node_name}" is the name advertised by the node during the opening of the connection. "$self->{host}" is the name of the node section in the master configuration. The new behaviour is the following: * "yes" -> "list" * "ignore" -> "list" * "no" -> "list $self->{host}" * any other value -> "list $self->{host}" This behaviour has the same effect as before, as the request for "list" (without a specific node name) is handley by munin-node exactly, as if its "node_name" is supplied.
sumpfralle
force-pushed
the
remove_use_node_name-ignore
branch
from
June 10, 2019 02:26
7a28b54 to
88e6b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values
yesandignoreforuse_node_namehave the same effect.The
ignorevalue was never documented anywhere.