Skip to content

Fix #153, use sizeof for snprintf buffer sizes in DS_SendHkCmd #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chillfig wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix #153, use sizeof for snprintf buffer sizes in DS_SendHkCmd #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions fsw/src/ds_cmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,13 +1526,16 @@ CFE_Status_t DS_SendHkCmd(const DS_SendHkCmd_t *BufPtr)
}

/* Get the filter table info, put the file name in the HK pkt. */
Status = snprintf(FilterTblName, CFE_MISSION_TBL_MAX_NAME_LENGTH, "DS.%s", DS_FILTER_TBL_NAME);
Status = snprintf(FilterTblName, sizeof(FilterTblName), "DS.%s", DS_FILTER_TBL_NAME);
if (Status >= 0)
{
Status = CFE_TBL_GetInfo(&FilterTblInfo, FilterTblName);
if (Status == CFE_SUCCESS)
{
snprintf(PayloadPtr->FilterTblFilename, OS_MAX_PATH_LEN, "%s", FilterTblInfo.LastFileLoaded);
snprintf(PayloadPtr->FilterTblFilename,
sizeof(PayloadPtr->FilterTblFilename),
"%s",
FilterTblInfo.LastFileLoaded);
}
else
{
Expand Down
Loading