fix(logrotate): handler no longer fails if all errors are about skipping rotation - #914
Open
marshallwp wants to merge 2 commits into
Open
fix(logrotate): handler no longer fails if all errors are about skipping rotation#914marshallwp wants to merge 2 commits into
marshallwp wants to merge 2 commits into
Conversation
…ing rotation The print logrotate error handler no longer fails if *all* errors are about rotation failing due to preexisting log files. If any of the errors are about something else, failure will occur as usual. This resolves nginx#913
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Moved the edit down one line to the `failed_when` line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The print logrotate error handler no longer fails if all errors are about rotation failing due to preexisting log files. If any of the errors are about something else, failure will occur as usual.
This resolves #913
Checklist
Before creating a PR, run through this checklist and mark each as complete:
defaults/main/*.yml,README.mdandCHANGELOG.md).