feat: Reduce "changed" strings in output - #927
Open
strugee wants to merge 1 commit into
Open
Conversation
The impetus for this change is that having the string "changed" in the output makes it annoying to run check mode and then do a find for "changed" to figure out what a real run would modify.
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The impetus for this change is that having the string "changed" in the output makes it annoying to run check mode and then do a find for "changed" to figure out what a real run would modify.
Notice that, while the
success_msgis no longer printed on success, the assertion failure formatting is still similar to what's printed before (though I would argue it's not great already...fail_msgdoesn't really print right). IMO given the fact that Ansible prints task names, thesuccess_msgisn't really adding much here, so this behavior seems ok.Before:
After:
Additional notes
I didn't run Molecule locally because this seemed so trivial that I figured I'd let CI take that job. Also, I did not adjust CHANGELOG.md because I was confused, see #926. Happy to amend the patch though, to add a changelog entry.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
defaults/main/*.yml,README.mdandCHANGELOG.md).