feat(gemma): add official Google QAT TP=4 profile - #815
Open
Whamp wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a supported four-card profile for Google's official
google/gemma-4-31B-it-qat-w4a16-ctcheckpoint:vllm/gemma-31b-multi-google-qat-w4a16⚠️ Production w/ caveatsThis solves the missing full-native-context Gemma option for four 3090s using Google's own QAT checkpoint. Compared with the same-session no-MTP baseline, n=2 changes narrative/code decode from 82.45/82.68 to 80.61/92.34 TPS: −2.2% narrative, +11.7% code, approximately +4.7% across the canonical pair. The trade-off is use of all four GPUs and a thin 1.2 GiB/card margin at near-max context.
Closes #814.
Type of change
Verification
switch.shmodels/gemma-4-31b/CHANGELOG.mdaddedMTP n-sweep
Every n=1–4 arm passed 20/20 repeated streamed two-tool calls with both argument objects preserved, confirming vLLM #45588 resolves the legacy Gemma MTP parser failure on v0.25.1.
The profile embeds a measured
MTP_ACCEPT_MIN=1.8. The generic 2.0 acceptance floor was tuned for deeper Qwen drafting; n=2 is independently throughput-positive and correctness-gated here.Operational gate
verify-full.sh: PASS without host overridesverify-stress.sh: PASS through 257,544 prompt tokens (98%)Full 8-pack quality
Repository guards
The full
scripts/tests/*.shsuite passes excepttest-switch-explain.sh. That test fails identically on unchanged master on this four-GPU host:vllm/defaultdetectsmulti4, but Qwen has no vLLM TP=4DEFAULTSrow. No profile-relevant guard fails.Full report and selected raw logs: https://gist.github.com/Whamp/742569247ce18c234bd3c7170d18b724
Caveats
Cross-links