app: Increase nRF provisioning stack size if Memfault is enabled - #407
Merged
juhaylinen merged 1 commit intoAug 18, 2026
Merged
Conversation
Memfault uses larger CoAP options than before, which increases stack usage in the nRF Provisioning thread. Enlarge the stack to prevent overflow. Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>
There was a problem hiding this comment.
Pull request overview
Adjusts Kconfig defaults to prevent stack overflow in the nRF Provisioning thread when Memfault is enabled, due to increased CoAP option sizing.
Changes:
- Adds a Memfault-conditional default for
NRF_PROVISIONING_STACK_SIZEto increase the provisioning thread stack. - Documents why the stack increase is needed (larger CoAP options increase request struct size on the stack).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MarkusLassila
approved these changes
Aug 18, 2026
|
Memory usage changed for nRF91M1 configuration. See CI run text data bss dec hex flash% ram%
--- baseline
+++ pr
@@ -2 +2 @@
- 319456 74588 166734 560778 88e8a 95.29% 81.83%
+ 319456 74588 167246 561290 8908a 95.29% 82.07% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memfault uses larger CoAP options than before, which increases stack usage in the nRF Provisioning thread. Enlarge the stack to prevent overflow.