sm_ppp_shell: Change to interrupt UART for shell - #408
Open
MarkusLassila wants to merge 1 commit into
Open
Conversation
MarkusLassila
requested review from
SeppoTakalo
and
a lite review from Copilot
August 19, 2026 06:06
There was a problem hiding this comment.
Pull request overview
This PR updates the samples/sm_ppp_shell sample configuration to use an interrupt-driven UART backend for the shell (instead of async), and increases relevant modem/shell buffer sizes to avoid freezes when handling long AT command/response payloads.
Changes:
- Increase modem UART/user-pipe and AT shell command/response buffer sizes in
prj.conf. - Switch shell backend to interrupt-driven UART on nRF54L15 DK configurations and set a larger serial RX ring buffer.
- Add an optional (commented) logging knob for URC visibility.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| samples/sm_ppp_shell/prj.conf | Enlarges modem and AT shell buffers; adjusts modem backend selection; adds optional URC logging line. |
| samples/sm_ppp_shell/boards/nrf54l15dk_nrf54l15_cpuapp.conf | Configures shell UART to use interrupt-driven backend with a larger RX ring buffer; keeps modem UART async. |
| samples/sm_ppp_shell/boards/nrf54l15dk_nrf54l15_cpuapp_ns.conf | Same as the non-NS config: interrupt-driven shell UART + large RX ring buffer; modem UART remains async. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use interrupt UART for the shell with sufficiently large buffer size to hold maximum expected AT-command. Async UART for shell freezes if a message exceeding buffers is copied, it has no flow control and maximum buffer size of 127*4. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
MarkusLassila
force-pushed
the
sm-ppp-shell-fota-dfu-fixes
branch
from
August 19, 2026 06:14
0a92141 to
0605927
Compare
|
Memory usage did not change for nRF91M1 configuration. See CI run |
trantanen
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use interrupt UART for the shell with sufficiently large buffer size to hold maximum expected AT-command.
Async UART for shell freezes if a message exceeding buffers is copied, it has no flow control and maximum buffer size of 127*4.