[14.0][ADD] document_page_archive_reason - #923
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #923 +/- ##
==========================================
+ Coverage 51.26% 51.53% +0.27%
==========================================
Files 1180 1187 +7
Lines 20388 20516 +128
Branches 4298 4309 +11
==========================================
+ Hits 10451 10573 +122
- Misses 9683 9687 +4
- Partials 254 256 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eantones
left a comment
There was a problem hiding this comment.
Review published with the requested changes in the line comments. Main points to address before merge:
- keep the archive flow on the normal
action_archive()path instead of writingactivedirectly; - add and maintain the internal current archive reason field;
- revalidate and sanitize the reason at confirm time, including escaping chatter HTML;
- keep unarchive aligned with standard Odoo behavior while clearing the stored reason only where needed;
- avoid exposing a generic context bypass for no-reason archiving;
- align tests with the natural wizard workflow;
- align wizard ACLs with users who can actually modify document pages;
- update the source README behavior description and regenerate derived artifacts after the code changes.
Please address the requested changes before merge.
|
@deeniiz I published the review as Please treat the review as request changes: address the line comments before merge, and ping me again once the PR is updated for re-review. |
4bc0714 to
8c04bc3
Compare
|
@eantones , can you please review it? |
028f70a to
4792b1f
Compare
4792b1f to
74db489
Compare
Supersedes #920
Split from #920. Odoo task: nuobit15-prod #2633 - [Qualitat] CONOCIMIENTO 5 - Arxiu amb motiu i nota automàtica.