[Ho Wei Yi Stanley] iP by beaniestanley · Pull Request #99 · nus-cs2113-AY2021S2/ip

beaniestanley · 2021-02-03T20:02:14Z

No description provided.

tehtea · 2021-02-04T02:40:01Z

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "\u2713" : " "); //return tick symbol if task is done


Perhaps this unicode can be replaced with a more expressive constant instead, so that the comment can be removed

Got it! Fixed :)

tehtea · 2021-02-04T02:44:42Z

+        System.out.println("\t__________________________________________\n");
+
+        ArrayList<Task> tasks = new ArrayList<Task>();
+        int taskCount = 0;


Instead of using the taskCount variable, is it possible to use tasks.length instead, so there is one less variable to manage?

Good idea. Fixed it already!

tehtea

Generally, no coding standard violations. Good job!

tehtea · 2021-02-04T03:02:34Z

+        this.by = by;
+    }
+
+    @Override


Neat use of method overriding too for each entity

tehtea · 2021-02-04T03:05:40Z

+                    // sets a task as done
+                    System.out.println("\tGreat job! I've marked this task as done: ");
+                    Task task = tasks.get(taskIndex - 1);
+                    task.markAsDone();


All method names are in camelCase too

AlexanderTanJunAn

Great job overall!

AlexanderTanJunAn · 2021-02-05T00:49:13Z

+        System.out.println("\t__________________________________________\n");
+
+        ArrayList<Task> tasks = new ArrayList<>();
+        boolean runLoop = true;


Naming of boolean variable is very readable. Very good!

AlexanderTanJunAn · 2021-02-05T00:51:10Z

+        this.at= at;
+    }
+
+    @Override


Good use of method overriding, allows Event class to inherit from parent Task class. Very good!

AlexanderTanJunAn · 2021-02-05T00:54:01Z

+                    // if list is empty
+                    System.out.println("\tYour list is empty!");
+                }
+                else {


If else statements should follow proper code standards! Small issue as the other statements follow them.

AlexanderTanJunAn · 2021-02-05T00:58:23Z

+        System.out.println("\tWhat can I help you with?");
+        System.out.println("\t__________________________________________\n");
+
+        ArrayList<Task> tasks = new ArrayList<>();


Collection of tasks is in plural form! Good!

lowwilliam

Overall good code quality! Clean and easy to understand and track!

lowwilliam · 2021-02-05T02:48:14Z

+        while (runLoop) {
+
+            String userInput = sc.nextLine().trim();
+


No need to leave space between these

lowwilliam · 2021-02-05T02:49:20Z

+
+    public Task(String description) {
+        this.description = description;
+        this.isDone = false;


good use of naming and Class with super

lowwilliam · 2021-02-05T02:51:12Z

+
+    @Override
+    public String toString() {
+        return "[D]" + super.toString() + "(by: " + this.by + ")";


This is a very clear structure of code, I will also apply this in mine

lowwilliam · 2021-02-05T02:56:57Z

+                System.out.println("\t__________________________________________\n");
+            } else {
+                // adds a task to the list
+                System.out.println("\t------------------------------------------");


I like the usage of a different form of lines, one:----- and one––––––––, it performs different meanings and let users easily understood.

baggiiiie · 2021-02-05T02:55:09Z

+
+            String userInput = sc.nextLine().trim();
+
+            if (userInput.equals("bye")) {


Could modify so that it is not case-sensitive

baggiiiie · 2021-02-05T02:59:12Z

+                runLoop = false;
+            } else if (userInput.equals("list")) {
+                System.out.println("\t------------------------------------------");
+                if (tasks.size() == 0) {


Good to check if the list is empty before printing out the list!

baggiiiie · 2021-02-05T03:01:34Z

+            } else {
+                // adds a task to the list
+                System.out.println("\t------------------------------------------");
+                switch(userInput.split(" ")[0]) {


could make a method to add task make code neater!

baggiiiie · 2021-02-05T03:04:36Z

+                    break;
+                case "event":
+                    // adds event tasks
+                    Task event = new Event(userInput.substring(6, userInput.indexOf("/at")),


userInput.indexOf("/at")+4 could be confusing

rabhijit

Good work! I think you follow code naming conventions and coding standards well. I think you could work on simplifying and breaking down complicated expressions and methods; readability is the name of the game here. Additionally, consider code organisation; you could split your code into more classes, as a lot of your program's functionality seems to be happening in just one class.

rabhijit · 2021-02-21T05:37:12Z

+
+    public Deadline(String description, String by) {
+        super(description);
+        this.by = by;


Consider using a more descriptive variable name that better illustrates what the variable represents.

rabhijit · 2021-02-21T05:39:57Z

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " ");


Though I understand what you're doing here, from a code readability standpoint, it's best to avoid conditionals in favour of a more explicit and clear if-else statement.

rabhijit · 2021-02-21T05:42:54Z

+
+    public static void exitProgram() {
+        // exits the program
+        System.out.println("\t------------------------------------------");


If you're using this string a lot, perhaps consider storing it as a constant variable that you could re-use elegantly.

rabhijit · 2021-02-21T05:46:14Z

+    }
+
+    public static void markTask(String userInput, ArrayList<Task> tasks) throws NumberFormatException,
+            IndexOutOfBoundsException {


Good that you followed wrapped-line indentation of 8 spaces!

rabhijit · 2021-02-21T05:49:52Z

+            } else if (userInput.split(" ")[0].equalsIgnoreCase("done")) {
+                markTask(userInput, tasks);
+            }
+            else if (userInput.split(" ")[0].equalsIgnoreCase("delete")) {


Perhaps you could avoid complicated (and repeated) expressions by breaking it down into multiple lines and storing it as a variable first; I noticed the same issue in a few other classes too, and it would help a reader understand your code better!

rabhijit · 2021-02-21T05:52:39Z

+        System.out.println("\t__________________________________________\n");
+    }
+
+    public static void addTask(String userInput, ArrayList<Task> tasks) throws StringIndexOutOfBoundsException {


This method is really long; consider breaking it down into smaller methods that would also make it easier for you to debug your own work. Maybe, upon doing so, you could move some of those methods to their relevant class (i.e. Deadline class, Event class, etc) to enhance code organisation

Add Level-9: Find

beaniestanley added 11 commits January 27, 2021 17:38

Added Level-0: Greet.

d8b5029

Added Level-1: Greet, Echo, Exit

a710370

Debug

9e06de3

Added Level-2: Add, List

53e4366

Added Level-1: Greet, Echo, Exit

f696b11

Merge remote-tracking branch 'origin/master'

0826396

Add Level-3 and comply with coding standard

236e379

Comply to coding standards

79b8ee9

Add Level-4: ToDos, Events, Deadlines

dee65dc

Add text files for semi-automated test

6caaaf4

Edit comment and check code quality

e61fbcb

tehtea reviewed Feb 4, 2021

View reviewed changes

Comment thread src/main/java/Deadline.java Outdated

this.by = by;

}

@Override

tehtea Feb 4, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat use of method overriding too for each entity

tehtea reviewed Feb 4, 2021

View reviewed changes

Improve coding standard based on comments

5007ced

AlexanderTanJunAn reviewed Feb 5, 2021

View reviewed changes

lowwilliam reviewed Feb 5, 2021

View reviewed changes

baggiiiie reviewed Feb 5, 2021

View reviewed changes

beaniestanley added 5 commits February 5, 2021 11:24

Edit expected output file for UI testing

9c4ca50

Add error handling and improve code quality

d6f5511

Added Class package

c5a16a8

Add Class package

9eaf478

Add Level-6: Delete

9d57036

rabhijit reviewed Feb 21, 2021

View reviewed changes

beaniestanley added 4 commits March 5, 2021 14:57

Add Level-7: Save

28bda25

Add test file

b9e4e31

Merge branch 'branch-Level-7'

32f8268

Add Level-9: Find

6c55cb6

beaniestanley and others added 7 commits March 5, 2021 16:48

Merge pull request #1 from beaniestanley/branch-Level-9

a0cd9a9

Add Level-9: Find

Add javadocs

8a4f674

Merge remote-tracking branch 'origin/master'

d1f6497

Add javadocs for find method

46d5543

Debug and add UG draft

80b1963

Add Release v0.2 link

7b7abd2

Set theme jekyll-theme-cayman

459f62f


		String userInput = sc.nextLine().trim();

		if (userInput.equals("bye")) {

Uh oh!

Conversation

beaniestanley commented Feb 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tehtea left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexanderTanJunAn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lowwilliam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rabhijit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rabhijit left a comment •

edited

Loading