[Edly Irsyad] iP by edlyIrsyad · Pull Request #195 · nus-cs2113-AY2122S1/ip

edlyIrsyad · 2021-09-02T02:56:59Z

Add some paragraph to the README.md to explain ...
Also add a heading ...

# Conflicts: # src/main/java/Duke.java

xseh

Good job! Consider SLAPping more of the code and reduce duplicated code.

xseh · 2021-09-17T21:35:58Z

+
+    @Override
+    public String getSymbol() {
+        return "D"; // mark Deadlines with a "D"


Consider removing the comment since the code is self-explanatory.

xseh · 2021-09-17T21:50:41Z

-}
+        welcomeMessage();
+        ArrayList<Task> entries = new ArrayList<>();
+        String dukeDataPath = "C:\\Users\\edly1\\Documents\\ip\\data\\dukeData.txt";


If this is a constant, the constant names should be all uppercase using underscore to separate words.

xseh · 2021-09-17T21:53:25Z

+            switch (userCommand) {
+            case "list":
+                printLongLine();
+                System.out.println("Here are the tasks in your list:");
+                int i = 0;
+                for(Task entry : entries){
+                    System.out.println((i+1) + ". " + "[" + entry.getSymbol() + "] ["
+                            + entry.getStatusIcon() + "] " + entry.getDescription());
+                    i++;
+                }
+                printLongLine();
+                break;
+            case "todo":
+                if (userCommandDetails.equals("todo")) {
+                    System.out.println("Hey! The description of a todo cannot be empty...");
+                }
+                else {
+                    entries.add(entriesCount, new ToDo(userCommandDetails));
+                    System.out.println("Got it. I've added this task:");
+                    toBePrinted = "[" + entries.get(entriesCount).getSymbol() + "] ["
+                            + entries.get(entriesCount).getStatusIcon() + "] " + entries.get(entriesCount).description;
+                    System.out.println("   " + toBePrinted);
+                    entriesCount++;
+                    System.out.println("Now you have " + entriesCount + " tasks in the list.");
+                    try {
+                        writeToFile(dukeDataPath, toBePrinted + System.lineSeparator());
+                    } catch (IOException e) {
+                        System.out.println("Something went wrong: " + e.getMessage());
+                    }
+                }
+                break;
+            case "deadline":
+                int deadlineIndex = userCommandDetails.indexOf("/by");
+                String taskDescription = userCommandDetails.substring(0, deadlineIndex - 1);
+                String taskDeadline = userCommandDetails.substring(deadlineIndex);
+                entries.add(entriesCount, new Deadline(taskDescription, taskDeadline));
+                System.out.println("Got it. I've added this task:");
+                toBePrinted = "[" + entries.get(entriesCount).getSymbol() + "] ["
+                        + entries.get(entriesCount).getStatusIcon() + "] " + entries.get(entriesCount).description;
+                System.out.println("   " + toBePrinted);
+                entriesCount++;
+                System.out.println("Now you have " + entriesCount + " tasks in the list.");
+                try {
+                    writeToFile(dukeDataPath, toBePrinted + System.lineSeparator());
+                } catch (IOException e) {
+                    System.out.println("Something went wrong: " + e.getMessage());
+                }
+                break;
+            case "event":
+                int eventDateTimeIndex = userCommandDetails.indexOf("/at");
+                String eventDescription = userCommandDetails.substring(0, eventDateTimeIndex - 1);
+                String eventDateTime = userCommandDetails.substring(eventDateTimeIndex);
+                entries.add(entriesCount, new Event(eventDescription, eventDateTime));
+                System.out.println("Got it. I've added this task:");
+                toBePrinted = "[" + entries.get(entriesCount).getSymbol() + "] ["
+                        + entries.get(entriesCount).getStatusIcon() + "] " + entries.get(entriesCount).description;
+                System.out.println("   " + toBePrinted);
+                entriesCount++;
+                System.out.println("Now you have " + entriesCount + " tasks in the list.");
+                try {
+                    writeToFile(dukeDataPath, toBePrinted + System.lineSeparator());
+                } catch (IOException e) {
+                    System.out.println("Something went wrong: " + e.getMessage());
+                }
+                break;
+            case "done":
+                String stringTaskIndex = userMessage.substring(userMessage.indexOf(" ") + 1);
+                int intTaskIndex = Integer.parseInt(stringTaskIndex) - 1;
+                entries.get(intTaskIndex).isDone = true;
+                printLongLine();
+                System.out.println("Nice! I've marked this task as done:\n"
+                        + "   [" + entries.get(intTaskIndex).getSymbol()
+                        + "] [" + entries.get(intTaskIndex).getStatusIcon() + "] " + entries.get(intTaskIndex).description);
+                printLongLine();
+                break;
+            case "delete":
+                stringTaskIndex = userMessage.substring(userMessage.indexOf(" ") + 1);
+                intTaskIndex = Integer.parseInt(stringTaskIndex) - 1;
+                printLongLine();
+                System.out.println("Noted. I've removed this task:\n"
+                        + "   [" + entries.get(intTaskIndex).getSymbol()
+                        + "] [" + entries.get(intTaskIndex).getStatusIcon() + "] " + entries.get(intTaskIndex).description);
+                System.out.println("Now you have " + (entriesCount - 1) + " tasks in the list.");
+                printLongLine();
+                for (i = intTaskIndex; i < entriesCount - 1; i++) {
+                    entries.set(i, entries.get(i + 1));
+                }
+                entries.remove(entriesCount - 1);
+                entriesCount -= 1;
+                break;
+            default:
+                printLongLine();
+                System.out.println(userCommand + " is an invalid command, try again");
+                printLongLine();
+                break;
+            }
+            userMessage = in.nextLine();
+        }
+        farewellMessage();
+    }
+}


Function is too bulky and long (more than 30 LOC), consider breaking it down into smaller parts and SLAP it further.

xseh · 2021-09-17T21:56:34Z

+            String userCommand = userMessage.contains(" ")
+                    ? userMessage.substring(0, userMessage.indexOf(" ")): userMessage;
+            String userCommandDetails = userMessage.contains(" ")
+                    ? userMessage.substring(userMessage.indexOf(" ") + 1): userMessage;


Avoid complicated expressions. Consider breaking down the logic into multiple steps.

xseh · 2021-09-17T21:57:29Z

+                System.out.println("Here are the tasks in your list:");
+                int i = 0;
+                for(Task entry : entries){
+                    System.out.println((i+1) + ". " + "[" + entry.getSymbol() + "] ["


Provide adequate spacing for the code (i.e. i + 1 instead)

xseh · 2021-09-17T21:58:11Z

+                    try {
+                        writeToFile(dukeDataPath, toBePrinted + System.lineSeparator());
+                    } catch (IOException e) {
+                        System.out.println("Something went wrong: " + e.getMessage());


Avoid the use of magic strings. In this case, the error message can be extracted into a constant variable with a suitable name.

Also reduces duplicated code.

xseh · 2021-09-17T22:03:27Z

+                printLongLine();
+                System.out.println("Noted. I've removed this task:\n"
+                        + "   [" + entries.get(intTaskIndex).getSymbol()
+                        + "] [" + entries.get(intTaskIndex).getStatusIcon() + "] " + entries.get(intTaskIndex).description);


Line is too long (more than 120 characters). Consider separating the line into multiple lines.

Add Ui updates

edlyIrsyad added 5 commits August 19, 2021 22:46

Add Increment: Level-0

2ca6058

Add Level - 1

10ba1da

Add Level-2

b90d4e3

Level-3

eca446a

Add A-CodingStandard

168beaa

edlyIrsyad changed the title ~~Add an introduction to the README.md~~ [Edly Irsyad] iP Sep 2, 2021

edlyIrsyad added 15 commits September 2, 2021 13:05

Add Level-4

f4b4949

Add A-CodeQuality

5ac4a58

Add Level-5

5618bca

Add A-Packages

5cbca39

Add A-Exceptions

a2306a9

Add Test Commit

72a0b53

Add Another Test Commit

54bcd53

Merge branch 'branch-Level-5'

5edf6d7

Add Level-6

40728f4

Add A-Collections

0957d93

Add Level-7

c695218

Add minor change

540ecd5

Merge branch 'branch-Level-6'

03ddc96

Merge branch 'branch-Level-7'

1bd6a31

# Conflicts: # src/main/java/Duke.java

Add A-Jar

705b2fb

xseh reviewed Sep 17, 2021

View reviewed changes

edlyIrsyad and others added 8 commits September 28, 2021 21:08

Add A-MoreOOP

e9ce696

Add Level-9

682547b

Add A-JavaDoc

ffcb230

Add A-UserGuide

d89c914

Add branch-A-JavaDoc

40f25b2

Add Ui updates

9f2e73e

Merge pull request #1 from edlyIrsyad/branch-Level-9

d9556fc

Add Ui updates

Change Headings

6e8a540

edlyIrsyad and others added 2 commits October 5, 2021 14:50

Change Task Details

79954e0

Set theme jekyll-theme-merlot

23e3fb1

Navigation Menu

Uh oh!

[Edly Irsyad] iP - #195

[Edly Irsyad] iP#195
edlyIrsyad wants to merge 30 commits into
nus-cs2113-AY2122S1:masterfrom
edlyIrsyad:master

edlyIrsyad commented Sep 2, 2021

Uh oh!

xseh left a comment

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

xseh Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

edlyIrsyad commented Sep 2, 2021

Uh oh!

xseh left a comment

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

xseh Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants